Ensure compatibility with both sync and async contents managers #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #61, I inspected the class used by the instance bounded to
self.contents_manager
by printing its type before theshould_hide(...)
function returns. This is what I got before installing Jupytext.After installing Jupytext, the contents manager changed.
After digging for a while, Jupytext does not support an async contents manager and overrides the contents manager with a subclass of LargeFileManager since 1.14.3.
Along these lines, I came up with a change to ensure we can call both sync and async methods.