[MRG] Add jupyter-offlinenotebook extension #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the offlinenotebook extension to the base install. With this users can download their notebook even after the server has gone away.
This comment has been minimized.
This comment has been minimized.
Some versions of lab used by repo2docker are not compatible with the offlinenotebook extension. We try to install the extension and if it fails we move on without raising an error.
|
👍 to trying it out. |
markmo
pushed a commit
to markmo/repo2docker
that referenced
this pull request
Jan 22, 2021
[MRG] Add jupyter-offlinenotebook extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the offlinenotebook extension to the base install. With this
users can download their notebook even after the server has gone away.
The extension came out of ideas in jupyterhub/binderhub#1003.
I think we should give this a try and see what people say to it. You can demo it on https://github.com/manics/jupyter-offlinenotebook (has a binder link).