Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible to disable labextensions? #964

Closed
minrk opened this issue Sep 18, 2020 · 8 comments
Closed

possible to disable labextensions? #964

minrk opened this issue Sep 18, 2020 · 8 comments

Comments

@minrk
Copy link
Member

minrk commented Sep 18, 2020

I've been doing some repo2docker development recently, which means that the base conda environment is getting installed a lot. The big frustration in this process has ben that roughly half (or more) of my build time is spent in jupyter labextension install jupyter-offlinenotebook. That's more than two minutes per build (see #919 for an example breakdown of timings). I recognize that this is something most real users won't see since this layer will often be cached, but it's been pretty devastating for my development cycle.

Is there any way that we can cache labextensions separately, or make them optional? This is a useful extension for Binder, but it's really not beneficial and extremely costly for local repo2docker.

@manics
Copy link
Member

manics commented Sep 18, 2020

Longer term options:

Short term fix: maybe a docker environment variable that activates a "development" mode and skips the build step?

@ccordoba12
Copy link

ccordoba12 commented Oct 1, 2020

I came here to also mention this. I just noticed this new step when rebuilding our Binder images for Spyder (I don't remember it a week ago).

Binder is a very useful service and we're using it more and more in our organization. So please don't skew things to favor JupyterLab because that affects other projects that have no relation to it.

@manics
Copy link
Member

manics commented Oct 1, 2020

@ccordoba12 this isn't new, it's been in repo2docker since February: #845, and JupyterLab has been included for even longer.

@ccordoba12
Copy link

ccordoba12 commented Oct 1, 2020

Sorry, I just noticed it now (perhaps because I paid more attention to the logs this time). In any case, I think my second comment above is still valuable.

@manics
Copy link
Member

manics commented Oct 1, 2020

#868 is probably the best solution if it can be implemented, since in theory you could completely disable jupyterlab and notebook.

@meeseeksmachine
Copy link

This issue has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/jupyterlab-3-0-release-candidate-available/6248/4

@manics
Copy link
Member

manics commented May 17, 2021

Is there anything we want to do here? The original motivation (reduce build time) is no longer an issue due to the new JupyterLab 3 extension packaging system.

@yuvipanda
Copy link
Collaborator

Yeah, it's just a pip install now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants