Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#78 Re-enable jupyterlab.browser_check #386

Merged
merged 2 commits into from
Jul 25, 2024
Merged

#78 Re-enable jupyterlab.browser_check #386

merged 2 commits into from
Jul 25, 2024

Conversation

arjxn-py
Copy link
Member

Should potentially fix #78

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch arjxn-py/JupyterCAD/#78-re-enable-jupyterlab-browser-check

arjxn-py
arjxn-py commented Jul 25, 2024
View reviewed changes
Copy link
Member Author

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like build is passing nicely

.github/workflows/build.yml Outdated Show resolved Hide resolved
martinRenou
martinRenou approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit e7f8932 into jupytercad:main Jul 25, 2024
9 checks passed
@arjxn-py arjxn-py deleted the #78-re-enable-jupyterlab-browser-check branch September 12, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jupyterlab.browser_check is disabled
2 participants
@arjxn-py @martinRenou