Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jupyterlab.browser_check is disabled #78

Closed
trungleduc opened this issue Dec 21, 2022 · 3 comments · Fixed by #386
Closed

jupyterlab.browser_check is disabled #78

trungleduc opened this issue Dec 21, 2022 · 3 comments · Fixed by #386
Labels
maintenance

Comments

@trungleduc
Copy link
Member

trungleduc commented Dec 21, 2022 •
edited
Loading

browser_check is broken with the changes in jupyter_server 2.0.2 (jupyter-server/jupyter_server#1143). It is disabled in our CI and should be re-enabled once it's fixed upstream.

Related PR #77
@trungleduc trungleduc added this to the 0.4.0 milestone Nov 9, 2023
@martinRenou martinRenou modified the milestones: 1.0.0, 2.0.0 Feb 8, 2024
@martinRenou martinRenou removed this from the 2.0.0 milestone Jun 14, 2024
@arjxn-py
Copy link
Member

@trungleduc Can it be re-enabled as the upstream issue is closed as completed?

@arjxn-py
Copy link
Member

arjxn-py commented Jul 24, 2024 •
edited
Loading

If you don't mind, I'd be happy to open up a quick PR for that & See if CI works nicely?

@trungleduc
Copy link
Member Author

yes, it would be great!

arjxn-py added a commit to arjxn-py/JupyterCAD that referenced this issue Jul 25, 2024
@arjxn-py
jupytercad#78 Re-enable jupyterlab.browser_check
1b47466
@arjxn-py arjxn-py mentioned this issue Jul 25, 2024
Merged
martinRenou pushed a commit that referenced this issue Jul 25, 2024
@arjxn-py
#78 Re-enable jupyterlab.browser_check (#386)
e7f8932 
* #78 Re-enable `jupyterlab.browser_check`

* Update .github/workflows/build.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#78 Re-enable jupyterlab.browser_check arjxn-py/JupyterCAD
3 participants
@trungleduc @martinRenou @arjxn-py