Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python_requires to help pip, and version classifers #57

Merged
merged 3 commits into from
Mar 18, 2019
Merged

Add python_requires to help pip, and version classifers #57

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb3eb58
Add python_requires to help pip, and version classifers
hugovk Jun 11, 2018
7ea8cd6
Remove x.y classifiers
hugovk Jun 11, 2018
a4c5a25
Correct field name
hugovk Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,15 @@ requires = [
"pywinpty (>=0.5);os_name=='nt'",
"tornado (>=4)",
]
python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My take is that this is more trouble than it's worth until we can express it concisely (>=3.4). But I'm open to other opinions.

The field in flit is called requires-python, though: http://flit.readthedocs.io/en/latest/pyproject_toml.html#metadata-section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've removed the x.y classifiers, and corrected this field.

classifiers=[
"Environment :: Web Environment",
"License :: OSI Approved :: BSD License",
"Programming Language :: Python :: 2",
"Programming Language :: Python :: 2.7",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.4",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in testpath, I don't like using these specific classifiers. They only get outdated and then need to be updated. If we need to specify Python version compatibility, requires-python is the way to do it.

"Topic :: Terminals :: Terminal Emulators/X Terminals",
]