-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python_requires to help pip, and version classifers #57
Conversation
The Travis failure is unrelated, latest master is failing in the same way: |
pyproject.toml
Outdated
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3.4", | ||
"Programming Language :: Python :: 3.5", | ||
"Programming Language :: Python :: 3.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in testpath
, I don't like using these specific classifiers. They only get outdated and then need to be updated. If we need to specify Python version compatibility, requires-python
is the way to do it.
pyproject.toml
Outdated
@@ -13,10 +13,15 @@ requires = [ | |||
"pywinpty (>=0.5);os_name=='nt'", | |||
"tornado (>=4)", | |||
] | |||
python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My take is that this is more trouble than it's worth until we can express it concisely (>=3.4
). But I'm open to other opinions.
The field in flit is called requires-python
, though: http://flit.readthedocs.io/en/latest/pyproject_toml.html#metadata-section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've removed the x.y classifiers, and corrected this field.
Thanks. I'll give other people a chance to opine on the use of the requires-python field here. |
The test failure on Py 2.7 seems to be reproducible. :-/ |
Close/reopen to rerun tests |
…y deps (since jupyter#65 isnt merged)
Based on the versions tested by .travis.yml, which match the supported CPython versions.
https://en.wikipedia.org/wiki/CPython#Version_history
And here's the pip installs for terminado from PyPI for May 2018:
Source:
pypinfo --start-date 2018-05-01 --end-date 2018-05-31 --percent --markdown terminado pyversion