Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Lumino 2 and JupyterLab 4.0.0a29 #6539

Merged
merged 49 commits into from
Oct 3, 2022
Merged

Update to Lumino 2 and JupyterLab 4.0.0a29 #6539

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
85ccd0e
Update to Lumino 2
afshin Sep 6, 2022
a4356bd
Update to JupyterLab 4.0.0a28
afshin Sep 6, 2022
9658583
Fix tests
afshin Sep 6, 2022
606bdde
More updates
afshin Sep 6, 2022
a339e46
Update to 4.0.0a29
afshin Sep 28, 2022
9ac7ad6
Update to alpha 29
afshin Sep 28, 2022
979fa75
Remove ypy-websocket explicit requirement
afshin Sep 28, 2022
61af08a
More updates
afshin Sep 28, 2022
aeac0de
Update yarn.lock
afshin Sep 28, 2022
0066002
rimraf innit
afshin Sep 29, 2022
1d99b10
Regenerate top-level yarn.lock
jtpio Sep 29, 2022
695f702
Update to Playwright 1.26
jtpio Sep 29, 2022
4c2342e
Update yarn.lock
jtpio Sep 29, 2022
cd02bd5
First pass on the notebook CSS
jtpio Sep 29, 2022
425339b
Update to TypeScript 4.7.3
jtpio Sep 30, 2022
7f68d4d
Change compilation target from ES2017 to ES2018
jtpio Sep 30, 2022
be427c4
Fix some Playwright selectors
jtpio Sep 30, 2022
e2a5983
Add lsp-extension
jtpio Sep 30, 2022
6e30026
Select kernel in the smoke test
jtpio Sep 30, 2022
1249974
Fix test for renaming a notebook
jtpio Sep 30, 2022
b9853d9
Partial fix for autoscroll outputs
jtpio Sep 30, 2022
ed2bae9
Fix test for renaming the yml file
jtpio Sep 30, 2022
b88195c
Remove custom test timeout
jtpio Sep 30, 2022
2e3a021
Tests: remove click on Select
jtpio Sep 30, 2022
0c2ba49
Fix horizontal scrollbar
jtpio Sep 30, 2022
a1de264
Increase ui tests workflow timeout
jtpio Sep 30, 2022
995bc9a
Update some reference snapshots
jtpio Oct 1, 2022
967d46c
Update Notebook CSS
jtpio Oct 1, 2022
228dbb2
Update one more reference snapshot
jtpio Oct 1, 2022
664c73c
Fix collapser and side-by-side rendering
jtpio Oct 1, 2022
346bd39
Add some left right margins
jtpio Oct 1, 2022
b4a5431
Fix notebook margins
jtpio Oct 1, 2022
656e6fd
Fix box shadows
jtpio Oct 1, 2022
59f97b0
More CSS fixes for the virtual notebook
jtpio Oct 1, 2022
15fe46b
Fix cell toolbar on mobile
jtpio Oct 1, 2022
2f56fcc
One more fix to the cell toolbar position
jtpio Oct 1, 2022
333cda9
Enable a bit scrolling past the notebook
jtpio Oct 1, 2022
de04c3f
Update more reference snapshots
jtpio Oct 2, 2022
993fc05
Update firefox snapshot
jtpio Oct 2, 2022
2d5e272
Add some comments to explain CSS customizations
jtpio Oct 2, 2022
b475821
Select kernel in the ui tests
jtpio Oct 2, 2022
c529ed9
Fix autoscroll logic
jtpio Oct 2, 2022
7e18565
Update notebook reference snapshot
jtpio Oct 3, 2022
4ae8e8d
Update helper to run a cell
jtpio Oct 3, 2022
6ac4a95
Fix selectors for autoscroll tests
jtpio Oct 3, 2022
6cc6a10
Add explicit video retain-on-failure
jtpio Oct 3, 2022
4200fb5
Fix some test wait conditions
jtpio Oct 3, 2022
2ac5247
Try fix the autoscroll tests
jtpio Oct 3, 2022
c1cd7b7
Update ref snapshot for Chromium
jtpio Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/build-dist/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ runs:
- name: Install dependencies
shell: bash
run: |
python -m pip install --upgrade jupyter_packaging~=0.10 "jupyterlab>=4.0.0a25,<5" ypy-websocket==0.2 build
python -m pip install --upgrade jupyter_packaging~=0.10 "jupyterlab>=4.0.0a29,<5" build

- name: Build pypi distributions
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/buildutils.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

- name: Install dependencies
run: |
python -m pip install -U "jupyterlab>=4.0.0a25,<5" ypy-websocket==0.2 hatch
python -m pip install -U "jupyterlab>=4.0.0a29,<5" hatch
jlpm
jlpm run build

Expand Down Expand Up @@ -76,6 +76,6 @@ jobs:

- name: Install dependencies
run: |
python -m pip install -U "jupyterlab>=4.0.0a25,<5" ypy-websocket==0.2 pip
python -m pip install -U "jupyterlab>=4.0.0a29,<5" pip
jlpm
jlpm run build
2 changes: 1 addition & 1 deletion app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ async function main() {
require('@jupyterlab/theme-dark-extension'),
require('@jupyterlab/translation-extension'),
// Add the "Hub Control Panel" menu option when running in JupyterHub
require('@jupyterlab/user-extension'),
require('@jupyterlab/collaboration-extension'),
require('@jupyterlab/hub-extension')
];

Expand Down
212 changes: 106 additions & 106 deletions app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,76 +22,76 @@
"@jupyter-notebook/tree": "~7.0.0-alpha.5",
"@jupyter-notebook/tree-extension": "~7.0.0-alpha.5",
"@jupyter-notebook/ui-components": "~7.0.0-alpha.5",
"@jupyterlab/application": "~4.0.0-alpha.10",
"@jupyterlab/application-extension": "~4.0.0-alpha.10",
"@jupyterlab/apputils": "~4.0.0-alpha.10",
"@jupyterlab/apputils-extension": "~4.0.0-alpha.10",
"@jupyterlab/cell-toolbar": "~4.0.0-alpha.10",
"@jupyterlab/cell-toolbar-extension": "~4.0.0-alpha.10",
"@jupyterlab/celltags": "~4.0.0-alpha.10",
"@jupyterlab/codeeditor": "~4.0.0-alpha.10",
"@jupyterlab/codemirror-extension": "~4.0.0-alpha.10",
"@jupyterlab/completer": "~4.0.0-alpha.10",
"@jupyterlab/completer-extension": "~4.0.0-alpha.10",
"@jupyterlab/console": "~4.0.0-alpha.10",
"@jupyterlab/console-extension": "~4.0.0-alpha.10",
"@jupyterlab/coreutils": "~6.0.0-alpha.10",
"@jupyterlab/docmanager": "~4.0.0-alpha.10",
"@jupyterlab/docmanager-extension": "~4.0.0-alpha.10",
"@jupyterlab/docprovider": "~4.0.0-alpha.10",
"@jupyterlab/docprovider-extension": "~4.0.0-alpha.10",
"@jupyterlab/documentsearch": "~4.0.0-alpha.10",
"@jupyterlab/documentsearch-extension": "~4.0.0-alpha.10",
"@jupyterlab/filebrowser": "~4.0.0-alpha.10",
"@jupyterlab/filebrowser-extension": "~4.0.0-alpha.10",
"@jupyterlab/fileeditor": "~4.0.0-alpha.10",
"@jupyterlab/fileeditor-extension": "~4.0.0-alpha.10",
"@jupyterlab/hub-extension": "~4.0.0-alpha.10",
"@jupyterlab/javascript-extension": "~4.0.0-alpha.10",
"@jupyterlab/json-extension": "~4.0.0-alpha.10",
"@jupyterlab/mainmenu": "~4.0.0-alpha.10",
"@jupyterlab/mainmenu-extension": "~4.0.0-alpha.10",
"@jupyterlab/markedparser-extension": "~4.0.0-alpha.10",
"@jupyterlab/mathjax2-extension": "~4.0.0-alpha.10",
"@jupyterlab/notebook": "~4.0.0-alpha.10",
"@jupyterlab/notebook-extension": "~4.0.0-alpha.10",
"@jupyterlab/observables": "~5.0.0-alpha.10",
"@jupyterlab/outputarea": "~4.0.0-alpha.10",
"@jupyterlab/pdf-extension": "~4.0.0-alpha.10",
"@jupyterlab/rendermime": "~4.0.0-alpha.10",
"@jupyterlab/rendermime-extension": "~4.0.0-alpha.10",
"@jupyterlab/rendermime-interfaces": "~3.8.0-alpha.10",
"@jupyterlab/running-extension": "~4.0.0-alpha.10",
"@jupyterlab/services": "~7.0.0-alpha.10",
"@jupyterlab/settingregistry": "~4.0.0-alpha.10",
"@jupyterlab/shared-models": "~4.0.0-alpha.10",
"@jupyterlab/shortcuts-extension": "~4.0.0-alpha.10",
"@jupyterlab/statedb": "~4.0.0-alpha.10",
"@jupyterlab/statusbar": "~4.0.0-alpha.10",
"@jupyterlab/terminal": "~4.0.0-alpha.10",
"@jupyterlab/terminal-extension": "~4.0.0-alpha.10",
"@jupyterlab/theme-dark-extension": "~4.0.0-alpha.10",
"@jupyterlab/theme-light-extension": "~4.0.0-alpha.10",
"@jupyterlab/tooltip": "~4.0.0-alpha.10",
"@jupyterlab/tooltip-extension": "~4.0.0-alpha.10",
"@jupyterlab/translation": "~4.0.0-alpha.10",
"@jupyterlab/translation-extension": "~4.0.0-alpha.10",
"@jupyterlab/ui-components": "~4.0.0-alpha.25",
"@jupyterlab/user": "~4.0.0-alpha.10",
"@jupyterlab/user-extension": "~4.0.0-alpha.10",
"@jupyterlab/vega5-extension": "~4.0.0-alpha.10",
"@lumino/algorithm": "~1.9.1",
"@lumino/application": "~1.29.0",
"@lumino/commands": "~1.20.0",
"@lumino/coreutils": "~1.12.0",
"@lumino/disposable": "~1.10.1",
"@lumino/domutils": "~1.8.1",
"@lumino/dragdrop": "~1.14.0",
"@lumino/messaging": "~1.10.1",
"@lumino/properties": "~1.8.1",
"@lumino/signaling": "~1.10.1",
"@lumino/virtualdom": "~1.14.1",
"@lumino/widgets": "~1.32.0",
"@jupyterlab/application": "~4.0.0-alpha.14",
"@jupyterlab/application-extension": "~4.0.0-alpha.14",
"@jupyterlab/apputils": "~4.0.0-alpha.14",
"@jupyterlab/apputils-extension": "~4.0.0-alpha.14",
"@jupyterlab/cell-toolbar": "~4.0.0-alpha.14",
"@jupyterlab/cell-toolbar-extension": "~4.0.0-alpha.14",
"@jupyterlab/celltags": "~4.0.0-alpha.14",
"@jupyterlab/codeeditor": "~4.0.0-alpha.14",
"@jupyterlab/codemirror-extension": "~4.0.0-alpha.14",
"@jupyterlab/collaboration": "~4.0.0-alpha.14",
"@jupyterlab/collaboration-extension": "~4.0.0-alpha.14",
"@jupyterlab/completer": "~4.0.0-alpha.14",
"@jupyterlab/completer-extension": "~4.0.0-alpha.14",
"@jupyterlab/console": "~4.0.0-alpha.14",
"@jupyterlab/console-extension": "~4.0.0-alpha.14",
"@jupyterlab/coreutils": "~6.0.0-alpha.14",
"@jupyterlab/docmanager": "~4.0.0-alpha.14",
"@jupyterlab/docmanager-extension": "~4.0.0-alpha.14",
"@jupyterlab/docprovider": "~4.0.0-alpha.14",
"@jupyterlab/docprovider-extension": "~4.0.0-alpha.14",
"@jupyterlab/documentsearch": "~4.0.0-alpha.14",
"@jupyterlab/documentsearch-extension": "~4.0.0-alpha.14",
"@jupyterlab/filebrowser": "~4.0.0-alpha.14",
"@jupyterlab/filebrowser-extension": "~4.0.0-alpha.14",
"@jupyterlab/fileeditor": "~4.0.0-alpha.14",
"@jupyterlab/fileeditor-extension": "~4.0.0-alpha.14",
"@jupyterlab/hub-extension": "~4.0.0-alpha.14",
"@jupyterlab/javascript-extension": "~4.0.0-alpha.14",
"@jupyterlab/json-extension": "~4.0.0-alpha.14",
"@jupyterlab/mainmenu": "~4.0.0-alpha.14",
"@jupyterlab/mainmenu-extension": "~4.0.0-alpha.14",
"@jupyterlab/markedparser-extension": "~4.0.0-alpha.14",
"@jupyterlab/mathjax2-extension": "~4.0.0-alpha.14",
"@jupyterlab/notebook": "~4.0.0-alpha.14",
"@jupyterlab/notebook-extension": "~4.0.0-alpha.14",
"@jupyterlab/observables": "~5.0.0-alpha.14",
"@jupyterlab/outputarea": "~4.0.0-alpha.14",
"@jupyterlab/pdf-extension": "~4.0.0-alpha.14",
"@jupyterlab/rendermime": "~4.0.0-alpha.14",
"@jupyterlab/rendermime-extension": "~4.0.0-alpha.14",
"@jupyterlab/rendermime-interfaces": "~3.8.0-alpha.14",
"@jupyterlab/running-extension": "~4.0.0-alpha.14",
"@jupyterlab/services": "~7.0.0-alpha.14",
"@jupyterlab/settingregistry": "~4.0.0-alpha.14",
"@jupyterlab/shared-models": "~4.0.0-alpha.14",
"@jupyterlab/shortcuts-extension": "~4.0.0-alpha.14",
"@jupyterlab/statedb": "~4.0.0-alpha.14",
"@jupyterlab/statusbar": "~4.0.0-alpha.14",
"@jupyterlab/terminal": "~4.0.0-alpha.14",
"@jupyterlab/terminal-extension": "~4.0.0-alpha.14",
"@jupyterlab/theme-dark-extension": "~4.0.0-alpha.14",
"@jupyterlab/theme-light-extension": "~4.0.0-alpha.14",
"@jupyterlab/tooltip": "~4.0.0-alpha.14",
"@jupyterlab/tooltip-extension": "~4.0.0-alpha.14",
"@jupyterlab/translation": "~4.0.0-alpha.14",
"@jupyterlab/translation-extension": "~4.0.0-alpha.14",
"@jupyterlab/ui-components": "~4.0.0-alpha.29",
"@jupyterlab/vega5-extension": "~4.0.0-alpha.14",
"@lumino/algorithm": "^2.0.0-alpha.6",
"@lumino/application": "^2.0.0-alpha.6",
"@lumino/commands": "^2.0.0-alpha.6",
"@lumino/coreutils": "^2.0.0-alpha.6",
"@lumino/disposable": "^2.0.0-alpha.6",
"@lumino/domutils": "^2.0.0-alpha.6",
"@lumino/dragdrop": "^2.0.0-alpha.6",
"@lumino/messaging": "^2.0.0-alpha.6",
"@lumino/properties": "^2.0.0-alpha.6",
"@lumino/signaling": "^2.0.0-alpha.6",
"@lumino/virtualdom": "^2.0.0-alpha.6",
"@lumino/widgets": "^2.0.0-alpha.6",
"react": "~17.0.2",
"react-dom": "~17.0.2",
"yjs": "~13.5.38"
Expand All @@ -108,41 +108,41 @@
"@jupyter-notebook/tree": "^7.0.0-alpha.5",
"@jupyter-notebook/tree-extension": "^7.0.0-alpha.5",
"@jupyter-notebook/ui-components": "^7.0.0-alpha.5",
"@jupyterlab/application-extension": "^4.0.0-alpha.10",
"@jupyterlab/apputils-extension": "^4.0.0-alpha.10",
"@jupyterlab/cell-toolbar-extension": "^4.0.0-alpha.10",
"@jupyterlab/celltags": "^4.0.0-alpha.10",
"@jupyterlab/codemirror-extension": "^4.0.0-alpha.10",
"@jupyterlab/completer-extension": "^4.0.0-alpha.10",
"@jupyterlab/console-extension": "^4.0.0-alpha.10",
"@jupyterlab/coreutils": "~6.0.0-alpha.10",
"@jupyterlab/docmanager-extension": "^4.0.0-alpha.10",
"@jupyterlab/docprovider-extension": "^4.0.0-alpha.10",
"@jupyterlab/documentsearch-extension": "^4.0.0-alpha.10",
"@jupyterlab/filebrowser-extension": "^4.0.0-alpha.10",
"@jupyterlab/fileeditor-extension": "^4.0.0-alpha.10",
"@jupyterlab/hub-extension": "^4.0.0-alpha.10",
"@jupyterlab/javascript-extension": "^4.0.0-alpha.10",
"@jupyterlab/json-extension": "^4.0.0-alpha.10",
"@jupyterlab/mainmenu-extension": "^4.0.0-alpha.10",
"@jupyterlab/markedparser-extension": "^4.0.0-alpha.10",
"@jupyterlab/mathjax2-extension": "^4.0.0-alpha.10",
"@jupyterlab/notebook-extension": "^4.0.0-alpha.10",
"@jupyterlab/pdf-extension": "^4.0.0-alpha.10",
"@jupyterlab/rendermime-extension": "^4.0.0-alpha.10",
"@jupyterlab/running-extension": "^4.0.0-alpha.10",
"@jupyterlab/shortcuts-extension": "^4.0.0-alpha.10",
"@jupyterlab/terminal-extension": "^4.0.0-alpha.10",
"@jupyterlab/theme-dark-extension": "^4.0.0-alpha.10",
"@jupyterlab/theme-light-extension": "^4.0.0-alpha.10",
"@jupyterlab/tooltip-extension": "^4.0.0-alpha.10",
"@jupyterlab/translation-extension": "^4.0.0-alpha.10",
"@jupyterlab/user-extension": "^4.0.0-alpha.10",
"@jupyterlab/vega5-extension": "^4.0.0-alpha.10"
"@jupyterlab/application-extension": "^4.0.0-alpha.14",
"@jupyterlab/apputils-extension": "^4.0.0-alpha.14",
"@jupyterlab/cell-toolbar-extension": "^4.0.0-alpha.14",
"@jupyterlab/celltags": "^4.0.0-alpha.14",
"@jupyterlab/collaboration-extension": "^4.0.0-alpha.14",
"@jupyterlab/codemirror-extension": "^4.0.0-alpha.14",
"@jupyterlab/completer-extension": "^4.0.0-alpha.14",
"@jupyterlab/console-extension": "^4.0.0-alpha.14",
"@jupyterlab/coreutils": "^6.0.0-alpha.14",
"@jupyterlab/docmanager-extension": "^4.0.0-alpha.14",
"@jupyterlab/docprovider-extension": "^4.0.0-alpha.14",
"@jupyterlab/documentsearch-extension": "^4.0.0-alpha.14",
"@jupyterlab/filebrowser-extension": "^4.0.0-alpha.14",
"@jupyterlab/fileeditor-extension": "^4.0.0-alpha.14",
"@jupyterlab/hub-extension": "^4.0.0-alpha.14",
"@jupyterlab/javascript-extension": "^4.0.0-alpha.14",
"@jupyterlab/json-extension": "^4.0.0-alpha.14",
"@jupyterlab/mainmenu-extension": "^4.0.0-alpha.14",
"@jupyterlab/markedparser-extension": "^4.0.0-alpha.14",
"@jupyterlab/mathjax2-extension": "^4.0.0-alpha.14",
"@jupyterlab/notebook-extension": "^4.0.0-alpha.14",
"@jupyterlab/pdf-extension": "^4.0.0-alpha.14",
"@jupyterlab/rendermime-extension": "^4.0.0-alpha.14",
"@jupyterlab/running-extension": "^4.0.0-alpha.14",
"@jupyterlab/shortcuts-extension": "^4.0.0-alpha.14",
"@jupyterlab/terminal-extension": "^4.0.0-alpha.14",
"@jupyterlab/theme-dark-extension": "^4.0.0-alpha.14",
"@jupyterlab/theme-light-extension": "^4.0.0-alpha.14",
"@jupyterlab/tooltip-extension": "^4.0.0-alpha.14",
"@jupyterlab/translation-extension": "^4.0.0-alpha.14",
"@jupyterlab/vega5-extension": "^4.0.0-alpha.14"
},
"devDependencies": {
"@jupyterlab/builder": "^4.0.0-alpha.10",
"@jupyterlab/buildutils": "^4.0.0-alpha.10",
"@jupyterlab/builder": "^4.0.0-alpha.14",
"@jupyterlab/buildutils": "^4.0.0-alpha.14",
"@types/rimraf": "^3.0.0",
"css-loader": "~5.0.1",
"fs-extra": "^8.1.0",
Expand All @@ -163,6 +163,7 @@
"name": "Jupyter Notebook",
"extensions": [
"@jupyter-notebook/application-extension",
"@jupyterlab/collaboration-extension",
"@jupyter-notebook/console-extension",
"@jupyter-notebook/docmanager-extension",
"@jupyter-notebook/documentsearch-extension",
Expand Down Expand Up @@ -192,8 +193,7 @@
"@jupyterlab/theme-dark-extension",
"@jupyterlab/theme-light-extension",
"@jupyterlab/tooltip-extension",
"@jupyterlab/translation-extension",
"@jupyterlab/user-extension"
"@jupyterlab/translation-extension"
],
"singletonPackages": [
"@jupyter-notebook/tree",
Expand All @@ -202,6 +202,7 @@
"@jupyterlab/cell-toolbar",
"@jupyterlab/celltags",
"@jupyterlab/codeeditor",
"@jupyterlab/collaboration",
"@jupyterlab/completer",
"@jupyterlab/console",
"@jupyterlab/coreutils",
Expand All @@ -224,7 +225,6 @@
"@jupyterlab/terminal",
"@jupyterlab/tooltip",
"@jupyterlab/translation",
"@jupyterlab/user",
"@jupyterlab/ui-components",
"@lumino/algorithm",
"@lumino/application",
Expand Down
2 changes: 1 addition & 1 deletion buildutils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"watch": "tsc -w --listEmittedFiles"
},
"dependencies": {
"@jupyterlab/buildutils": "^4.0.0-alpha.10",
"@jupyterlab/buildutils": "^4.0.0-alpha.14",
"commander": "^6.2.0",
"fs-extra": "^9.1.0",
"typescript": "~4.6.3"
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"watch:lib": "lerna exec --stream --scope @jupyter-notebook/metapackage jlpm watch"
},
"devDependencies": {
"@jupyterlab/buildutils": "^4.0.0-alpha.10",
"@jupyterlab/buildutils": "^4.0.0-alpha.14",
"@typescript-eslint/eslint-plugin": "^4.2.0",
"@typescript-eslint/parser": "^4.2.0",
"eslint": "^7.10.0",
Expand Down
30 changes: 15 additions & 15 deletions packages/application-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,21 +41,21 @@
"dependencies": {
"@jupyter-notebook/application": "^7.0.0-alpha.5",
"@jupyter-notebook/ui-components": "^7.0.0-alpha.5",
"@jupyterlab/application": "^4.0.0-alpha.10",
"@jupyterlab/apputils": "^4.0.0-alpha.10",
"@jupyterlab/celltags": "^4.0.0-alpha.10",
"@jupyterlab/codeeditor": "^4.0.0-alpha.10",
"@jupyterlab/codemirror": "^4.0.0-alpha.10",
"@jupyterlab/console": "^4.0.0-alpha.10",
"@jupyterlab/coreutils": "^6.0.0-alpha.10",
"@jupyterlab/docmanager": "^4.0.0-alpha.10",
"@jupyterlab/docregistry": "^4.0.0-alpha.10",
"@jupyterlab/mainmenu": "^4.0.0-alpha.10",
"@jupyterlab/settingregistry": "^4.0.0-alpha.10",
"@jupyterlab/translation": "^4.0.0-alpha.10",
"@lumino/coreutils": "^1.12.0",
"@lumino/disposable": "^1.10.1",
"@lumino/widgets": "^1.32.0"
"@jupyterlab/application": "^4.0.0-alpha.14",
"@jupyterlab/apputils": "^4.0.0-alpha.14",
"@jupyterlab/celltags": "^4.0.0-alpha.14",
"@jupyterlab/codeeditor": "^4.0.0-alpha.14",
"@jupyterlab/codemirror": "^4.0.0-alpha.14",
"@jupyterlab/console": "^4.0.0-alpha.14",
"@jupyterlab/coreutils": "^6.0.0-alpha.14",
"@jupyterlab/docmanager": "^4.0.0-alpha.14",
"@jupyterlab/docregistry": "^4.0.0-alpha.14",
"@jupyterlab/mainmenu": "^4.0.0-alpha.14",
"@jupyterlab/settingregistry": "^4.0.0-alpha.14",
"@jupyterlab/translation": "^4.0.0-alpha.14",
"@lumino/coreutils": "^2.0.0-alpha.6",
"@lumino/disposable": "^2.0.0-alpha.6",
"@lumino/widgets": "^2.0.0-alpha.6"
},
"devDependencies": {
"rimraf": "~3.0.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/application-extension/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ const title: JupyterFrontEndPlugin<void> = {
return;
}

const result = await renameDialog(docManager, current.context.path);
const result = await renameDialog(docManager, current.context);

// activate the current widget to bring the focus
if (current) {
Expand All @@ -453,7 +453,7 @@ const title: JupyterFrontEndPlugin<void> = {
return;
}

const newPath = current.context.path ?? result.path;
const newPath = current.context.path;
const basename = PathExt.basename(newPath);

h.textContent = basename.replace(STRIP_IPYNB, '');
Expand Down
24 changes: 12 additions & 12 deletions packages/application/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,22 @@
"watch": "tsc -b --watch"
},
"dependencies": {
"@jupyterlab/application": "^4.0.0-alpha.10",
"@jupyterlab/coreutils": "^6.0.0-alpha.10",
"@jupyterlab/docregistry": "^4.0.0-alpha.10",
"@jupyterlab/rendermime-interfaces": "^3.8.0-alpha.10",
"@jupyterlab/ui-components": "^4.0.0-alpha.25",
"@lumino/algorithm": "^1.9.1",
"@lumino/coreutils": "^1.12.0",
"@lumino/messaging": "^1.10.1",
"@lumino/polling": "^1.10.0",
"@lumino/signaling": "^1.10.1",
"@lumino/widgets": "^1.32.0"
"@jupyterlab/application": "^4.0.0-alpha.14",
"@jupyterlab/coreutils": "^6.0.0-alpha.14",
"@jupyterlab/docregistry": "^4.0.0-alpha.14",
"@jupyterlab/rendermime-interfaces": "^3.8.0-alpha.13",
"@jupyterlab/ui-components": "^4.0.0-alpha.29",
"@lumino/algorithm": "^2.0.0-alpha.6",
"@lumino/coreutils": "^2.0.0-alpha.6",
"@lumino/messaging": "^2.0.0-alpha.6",
"@lumino/polling": "^2.0.0-alpha.6",
"@lumino/signaling": "^2.0.0-alpha.6",
"@lumino/widgets": "^2.0.0-alpha.6"
},
"devDependencies": {
"@babel/core": "^7.11.6",
"@babel/preset-env": "^7.12.1",
"@jupyterlab/testutils": "^4.0.0-alpha.10",
"@jupyterlab/testutils": "^4.0.0-alpha.14",
"@types/jest": "^26.0.10",
"jest": "^26.4.2",
"rimraf": "~3.0.0",
Expand Down
Loading