-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Lumino 2 and JupyterLab 4.0.0a29 #6539
Conversation
Thanks @afshin for starting this. Do you want to take over the lab There are a couple of items to have a look listed in the top comment: #6525 (comment) |
a5f8376
to
dbbf5fa
Compare
@jtpio, sounds like a plan! I may ask you for advice if I run into any headaches 🤕 |
This migration will need to wait for a version of Lumino that includes the bug fix for startup plugins not activating and a new version of JupyterLab based with updated Lumino libraries. |
Looks like there is a new error coming from
EDIT: opened jupyter-server/jupyter_ydoc#58 |
Alright CI is all passing now ✔️ I also did a quick check on Binder and it seems to be looking good there as well. Found a new issue when opening a JSON file with the code editor, but it seems to be happening in JupyterLab too. Opened jupyterlab/jupyterlab#13170 so it can be fixed upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @afshin for starting this update.
In the end it required more changes than initially thought but it's looking good now 😅
Getting this one in and making a new release right after.
Thank you @jtpio! |
Resolves #6538
Fixes #6500
Closes #6533
ypy-websocket
to0.2
#6499lsp-extension
: Integratejupyterlab-lsp
intojupyterlab
jupyterlab/jupyterlab#12534@playwright/test
#6533