Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Lumino 2 and JupyterLab 4.0.0a29 #6539

Merged
merged 49 commits into from
Oct 3, 2022
Merged

Conversation

afshin
Copy link
Member

@afshin afshin commented Sep 6, 2022

Resolves #6538
Fixes #6500
Closes #6533

@afshin afshin added this to the 7.0 milestone Sep 6, 2022
@afshin afshin self-assigned this Sep 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Binder 👈 Launch a Binder on branch afshin/notebook/lumino-2

@afshin afshin added maintenance dependencies Pull requests that update a dependency file labels Sep 6, 2022
@jtpio
Copy link
Member

jtpio commented Sep 6, 2022

Thanks @afshin for starting this.

Do you want to take over the lab 4.0.0a27 update as well, which was started in #6525 and has some overlap with the current PR? If so happy to close #6525 then.

There are a couple of items to have a look listed in the top comment: #6525 (comment)

@afshin afshin force-pushed the lumino-2 branch 2 times, most recently from a5f8376 to dbbf5fa Compare September 6, 2022 10:28
@afshin
Copy link
Member Author

afshin commented Sep 6, 2022

@jtpio, sounds like a plan! I may ask you for advice if I run into any headaches 🤕

@afshin
Copy link
Member Author

afshin commented Sep 6, 2022

This migration will need to wait for a version of Lumino that includes the bug fix for startup plugins not activating and a new version of JupyterLab based with updated Lumino libraries.

@jtpio
Copy link
Member

jtpio commented Sep 28, 2022

Looks like there is a new error coming from jupyter_ydoc: https://github.com/jupyter/notebook/actions/runs/3145280672/jobs/5112365511

lerna ERR! yarn run build:prod stderr:
Traceback (most recent call last):
  File "/tmp/build-env-sga8vbqf/bin/jupyter-labextension", line 5, in <module>
    from jupyterlab.labextensions import main
  File "/tmp/build-env-sga8vbqf/lib/python3.10/site-packages/jupyterlab/labextensions.py", line 37, in <module>
    from .labapp import LabApp
  File "/tmp/build-env-sga8vbqf/lib/python3.10/site-packages/jupyterlab/labapp.py", line 15, in <module>
    from jupyter_server_ydoc.ydoc import JupyterSQLiteYStore
  File "/tmp/build-env-sga8vbqf/lib/python3.10/site-packages/jupyter_server_ydoc/__init__.py", line 6, in <module>
    from .ydoc import YDocWebSocketHandler
  File "/tmp/build-env-sga8vbqf/lib/python3.10/site-packages/jupyter_server_ydoc/ydoc.py", line 11, in <module>
    from jupyter_ydoc import ydocs as YDOCS  # type: ignore
  File "/tmp/build-env-sga8vbqf/lib/python3.10/site-packages/jupyter_ydoc/__init__.py", line 1, in <module>
    import pkg_resources

EDIT: opened jupyter-server/jupyter_ydoc#58

app/package.json Outdated Show resolved Hide resolved
@jtpio jtpio changed the title Update to Lumino 2 Update to Lumino 2 and JupyterLab 4.0.0a29 Sep 28, 2022
@jtpio jtpio linked an issue Sep 28, 2022 that may be closed by this pull request
3 tasks
pyproject.toml Outdated Show resolved Hide resolved
@jtpio jtpio marked this pull request as ready for review October 3, 2022 14:00
@jtpio
Copy link
Member

jtpio commented Oct 3, 2022

Alright CI is all passing now ✔️

I also did a quick check on Binder and it seems to be looking good there as well.

Found a new issue when opening a JSON file with the code editor, but it seems to be happening in JupyterLab too. Opened jupyterlab/jupyterlab#13170 so it can be fixed upstream.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afshin for starting this update.

In the end it required more changes than initially thought but it's looking good now 😅

Getting this one in and making a new release right after.

@jtpio jtpio merged commit acbec17 into jupyter:main Oct 3, 2022
@afshin
Copy link
Member Author

afshin commented Oct 3, 2022

Thank you @jtpio!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Notebook 7 to Lumino 2 Update to JupyterLab 4.0.0a27
2 participants