-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a copy capability to jupyter notebooks #3071
Conversation
Thanks! It will probably be a few days before I can look at this properly, but someone else might be able to have a look sooner. It looks like the CI tests have failed - can you have a look and see if that's related to the change you made? There is already a method |
notebook/static/base/js/namespace.js
Outdated
@@ -73,7 +73,7 @@ define(function(){ | |||
// tree | |||
jglobal('SessionList','tree/js/sessionlist'); | |||
|
|||
Jupyter.version = "5.2.1"; | |||
Jupyter.version = "5.3.0.dev0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agrippa I think version changes automatically when start developing the code base. And should be changed when we are making a PR, if I'm not mistaken.
I'm currently new to the codebase so I might be wrong in this. 😄
|
@takluyver Thanks for the feedback! I looked at just using copy() and did a bit of refactoring, is that along the lines of what you were thinking? |
That's a start, but I don't think we need the |
Thanks, @agrippa, for this work! This has been inactive for awhile, so I'm going to close this PR for now. I think it's a good feature to add at some point, but it looks like developer time is limited here. If anyone has time to devote to it, feel free reopen or resubmit a new PR. Thanks! |
This is a small change to add the ability to copy files in the Notebook UI, in addition to moving them. Because of my infamiliarity with the notebook code base, I tried to minimize the amount of changes necessary to achieve this. Mostly, this appropriates the same code paths as Move but adds a keep_old flag that indicates whether the source file should be cleared out (move) or not (copy).
This is my first pull request on the repo, so apologies if I skipped/mangled a whole bunch of steps in creating this pull request (as I imagine I may have).