Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-only notebooks can't be unlocked for editing #1324

Closed
PrinterOperator opened this issue Apr 8, 2016 · 5 comments · Fixed by #5296
Closed

Read-only notebooks can't be unlocked for editing #1324

PrinterOperator opened this issue Apr 8, 2016 · 5 comments · Fixed by #5296

Comments

@PrinterOperator
Copy link

This issue is open in the ipython project here, and it doesn't appear like it's been migrated to jupyter.

As mentioned in that thread, it would be great to either have a "Save As" feature or to not allow editing of a read-only file.

@MikeDacre
Copy link

Has there been any further work on this?

I accidentally extensively edited a notebook that was read-only on the disk and my changes are permanently lost it seems; despite having the window open I can find no mechanism other than copying and pasting every cell to save my changes, even after the notebook is made writable on the disk.

@benjaminleighton
Copy link

I had a file on disk with read-only permissions and I modified it to be able it to be written but I was still not able to save my notebook after extensive edits. As a workaround, using the web browser debugger, I put a break point in Notebook.prototype.save_notebook and set this.writable = true. I was then able to save the notebook and retain my changes.

@Madhu94
Copy link
Contributor

Madhu94 commented Jan 26, 2018

@gnestor @takluyver I noticed that the copy handler does accept a 'to_path', but the POST calls from contents.js on the client side only set the copy_from. Would you be open to accepting a PR for the Save as feature ?

I'm thinking of adding a modal that lets the user enter a path, checks if the user has permissions to write to that path and if so, save it there.

This would be great for copying shared read-only notebooks as well.

@takluyver
Copy link
Member

Yes, I think so. There's a PR here, but it seems to have stalled: #3071

@toonijn
Copy link
Contributor

toonijn commented Mar 5, 2020

This is still an issue.

Is someone working on this?
Else I will implement this myself, with inspiration from: pangeo-data/helm-chart#44 (comment)

toonijn added a commit to toonijn/notebook that referenced this issue Mar 18, 2020
toonijn added a commit to toonijn/notebook that referenced this issue Apr 9, 2020
blink1073 pushed a commit that referenced this issue May 22, 2020
* add failing test for readonly notebook

* test typing after save-as

* make notebook writable after save-as
fixes #1324

* fix failing test in travis
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants