-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backspace doesn't delete empty line #5502
Labels
Milestone
Comments
Thanks for running master and finding the commit. Assigning to the 6.0.4 milestone so we don't ship broken code. |
@benthayer - would you be able to look into this as it appears related to #4880? |
Yes, I'll check it out this weekend. I think this code is pretty similar to the code I used to fix this in jupyterlab/jupyterlab#7401, so I'll check to see if that's an issue as well |
benthayer
added a commit
to benthayer/notebook
that referenced
this issue
Jun 6, 2020
blink1073
pushed a commit
that referenced
this issue
Jun 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug description:
In a code cell, pressing backspace removes characters correctly until it reaches the beginning of the line. Then, it fails to delete the empty line and go up.
I stepped through the recent commits and tested them. Apparently d406b8c is causing the problem.
The text was updated successfully, but these errors were encountered: