Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backspace doesn't delete empty line #5502

Closed
m2-farzan opened this issue Jun 3, 2020 · 3 comments · Fixed by #5516
Closed

Backspace doesn't delete empty line #5502

m2-farzan opened this issue Jun 3, 2020 · 3 comments · Fixed by #5516

Comments

@m2-farzan
Copy link
Contributor

Bug description:

In a code cell, pressing backspace removes characters correctly until it reaches the beginning of the line. Then, it fails to delete the empty line and go up.

I stepped through the recent commits and tested them. Apparently d406b8c is causing the problem.

@jasongrout jasongrout added this to the 6.0.4 milestone Jun 3, 2020
@jasongrout
Copy link
Member

Thanks for running master and finding the commit. Assigning to the 6.0.4 milestone so we don't ship broken code.

@kevin-bates kevin-bates modified the milestones: 6.0.4, 6.1 Jun 4, 2020
@kevin-bates
Copy link
Member

@benthayer - would you be able to look into this as it appears related to #4880?

@kevin-bates kevin-bates mentioned this issue Jun 4, 2020
24 tasks
@benthayer
Copy link
Contributor

Yes, I'll check it out this weekend. I think this code is pretty similar to the code I used to fix this in jupyterlab/jupyterlab#7401, so I'll check to see if that's an issue as well

benthayer added a commit to benthayer/notebook that referenced this issue Jun 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants