-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 6.1.0 #5423
Comments
@blink1073 @kevin-bates Would it be possible to release a 6.0.4 with minimally the fix for #4835 which prevents installing in a Python 3 virtual environment? Installing Alternatively, 6.1 would be great too. 😄 |
Hi @willingc - thanks for the heads up. I'm a little confused in trying to understand your comment from an urgency perspective. Neither #4835 nor the fix I believe you're referring to (#5451) have been released - both in master waiting for their "carrier". So was your py3 installation issue the result of cherry-picking #4853 (having not also taken #5451)? Our intention is to build 6.1 from master but if there's more at play here I suppose we could look into an interim patch release. Although, having never built a notebook release, I should defer to Steve on that. I was going to suggest at least one rc release (for 6.1) so we can discover, and workout, any kinks as well. |
Release 6.1.0rc1 has been pushed to PyPI. Does conda-forge handle pre-releases? If so, I'd prefer to wait to announce the RC. I was going to post in the google groups, gitter, and discourse forums. Are there other locations? |
Thanks! Pre-releases on conda are possible: I added an I think those ANN locations sound good. |
Thanks Steve! I've submitted conda-forge/notebook-feedstock#68 targeting the rc branch and based on the jupyterlab example. |
@Zsailer, @blink1073, @afshin - could you please review the set of unmarked tasks above? I think we need to try to get 6.1 out soon (preferably next week) and I believe the unmarked items are ready (with the exception of #5259). Also, Steve, I noticed you marked some of these with a 6.2 milestone and I suspect that was to prevent 'feature creep'. Just wondering your thoughts on including them in 6.1? I'd like to go ahead and include the Russian I18N work since that's the kind of thing that shouldn't be too disruptive if there are issues that were not caught in review. Any objections? |
I just didn't want to step on your toes. I merged the ones that were waiting in the wings. |
Thank you for championing this forward, @kevin-bates! I merged #5593. I would think we should bump #5259 to 6.2, since there hasn't been activity on that PR in awhile.
👍 I agree! |
I agree with Zach. If they do not come back to update it, I can take a more serious look at that PR if we think it's important and we can put it in 6.2. |
Thank you for your timely responses and all your help! I'll finalize the changelog and let things sit for a day or so, then release 6.1.0 GA. |
6.1.0 is released - thank you all for your help with this! |
There have been some pull requests merged (and others waiting) that probably warrant more than a patch release, so I'd like to start the process of putting things together for a Notebook 6.1.0 release. Preferably, this would be based on master.
Here are the commits since 6.0.3, most of which came with #4479 - which is a primary reason for introducing a minor release.
Other PRs I think we should include - although I don't necessarily expect all these to make the release...
[WIP] Make the last modified date consider files in subdirectory [WIP] Make the last modified date consider files in subdirectory #5336 (front-end review required)(Zach, won't be ready in the near future).implement natural sorting fixes 5230 implement natural sorting fixes #5230 #5259 (front-end review required) (Darian: changes requested)(deferred to next release)Adjust buffer replay logic for restarts w/ new ports Adjust buffer replay logic for restarts w/ new ports #5450(deferred to jupyter_server)JUPYTER_TOKEN_FILE
Added support for JUPYTER_TOKEN_FILE #5587 (Kevin)If there are other issues and/or pull requests you'd like to see in a 6.1.0 release, please add comments and I'll amend this text - or feel free to amend this yourself (if privs allow).
The text was updated successfully, but these errors were encountered: