-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure collapsed mergepane border #731
Merged
Merged
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
2f377f4
Ensure dev build also copies styles etc
vidartf 7a97063
Ensure collapsed mergepane border
vidartf 9cba86d
Update Playwright Snapshots
github-actions[bot] 9695b00
Update Playwright Snapshots
github-actions[bot] f718b7b
Also add outer border for 1 and 2 pane
vidartf e56e9fa
Merge branch 'fix-mergepane-border' of https://github.com/vidartf/nbd…
vidartf 1240161
Update Playwright Snapshots
github-actions[bot] afbfc31
Update Playwright Snapshots
github-actions[bot] 4c853a6
Tweak styles to resemble previous version
vidartf 4fb6c35
Update Playwright Snapshots
github-actions[bot] 6519f67
Update Playwright Snapshots
github-actions[bot] 242b79e
Update packages/nbdime/src/styles/common.css
vidartf 51fda22
Tweak styles for border some more
vidartf d96d106
Update Playwright Snapshots
github-actions[bot] 8ddfd5b
Update Playwright Snapshots
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+41 Bytes
(100%)
...-diff-test1.spec.ts-snapshots/diff-test1-take-a-snapshot-at-opening-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+86 Bytes
(100%)
...-diff-test1.spec.ts-snapshots/diff-test1-take-a-snapshot-at-opening-1-win32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+49 Bytes
(100%)
...-diff-test2.spec.ts-snapshots/diff-test2-take-a-snapshot-at-opening-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+87 Bytes
(100%)
...-diff-test2.spec.ts-snapshots/diff-test2-take-a-snapshot-at-opening-1-win32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1020 Bytes
(100%)
...-diff-test3.spec.ts-snapshots/diff-test3-take-a-snapshot-at-opening-1-linux.png
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is nicer here indeed. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+711 Bytes
(100%)
...-diff-test3.spec.ts-snapshots/diff-test3-take-a-snapshot-at-opening-1-win32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7.22 KB
(72%)
ui-tests/tests/nbdime-merge-test1.spec.ts-snapshots/3-panels-view-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.02 KB
(76%)
ui-tests/tests/nbdime-merge-test1.spec.ts-snapshots/3-panels-view-1-win32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.31 KB
(82%)
...1.spec.ts-snapshots/merge-test1-choose-central-version-for-conflict-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.55 KB
(84%)
...1.spec.ts-snapshots/merge-test1-choose-central-version-for-conflict-1-win32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.31 KB
(82%)
...est1.spec.ts-snapshots/merge-test1-choose-left-version-for-conflict-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.55 KB
(84%)
...est1.spec.ts-snapshots/merge-test1-choose-left-version-for-conflict-1-win32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.31 KB
(82%)
...st1.spec.ts-snapshots/merge-test1-choose-right-version-for-conflict-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.55 KB
(84%)
...st1.spec.ts-snapshots/merge-test1-choose-right-version-for-conflict-1-win32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7.27 KB
(79%)
...erge-test1.spec.ts-snapshots/merge-test1-take-a-snapshot-at-opening-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.18 KB
(82%)
...erge-test1.spec.ts-snapshots/merge-test1-take-a-snapshot-at-opening-1-win32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.33 KB
(84%)
...me-merge-test2.spec.ts-snapshots/merge-test2-choose-central-version-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.68 KB
(85%)
...me-merge-test2.spec.ts-snapshots/merge-test2-choose-central-version-1-win32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.32 KB
(84%)
...bdime-merge-test2.spec.ts-snapshots/merge-test2-choose-left-version-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.69 KB
(85%)
...bdime-merge-test2.spec.ts-snapshots/merge-test2-choose-left-version-1-win32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.32 KB
(84%)
...dime-merge-test2.spec.ts-snapshots/merge-test2-choose-right-version-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.69 KB
(85%)
...dime-merge-test2.spec.ts-snapshots/merge-test2-choose-right-version-1-win32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.32 KB
(84%)
...erge-test2.spec.ts-snapshots/merge-test2-take-a-snapshot-at-opening-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.69 KB
(85%)
...erge-test2.spec.ts-snapshots/merge-test2-take-a-snapshot-at-opening-1-win32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-11.2 KB
(79%)
...s/merge-test4-should-synchronize-the-collapse-status-between-editor-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7.47 KB
(83%)
...s/merge-test4-should-synchronize-the-collapse-status-between-editor-1-win32.png
Oops, something went wrong.
Binary file modified
BIN
-15.2 KB
(89%)
...erge-test5.spec.ts-snapshots/merge-test5-take-a-snapshot-at-opening-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
-12.1 KB
(90%)
...erge-test5.spec.ts-snapshots/merge-test5-take-a-snapshot-at-opening-1-win32.png
Oops, something went wrong.
Binary file modified
BIN
-3.08 KB
(95%)
...erge-test6.spec.ts-snapshots/merge-test6-take-a-snapshot-at-opening-1-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.9 KB
(95%)
...erge-test6.spec.ts-snapshots/merge-test6-take-a-snapshot-at-opening-1-win32.png
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like the old version (a single green border) looked cleaner than the new one (a green border in grey outline).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right, probably the rule shouldn't be added for the 1-way.