Ensure collapsed mergepane border #731
Merged
Commits on Nov 6, 2023
-
-
Ensure collapsed mergepane border
After switching to grid based layout, each pane had its own border. With 0px gap, the border still did not collapse to single 1px border, so instead we switch to using gap + background-color. C.f. https://stackoverflow.com/questions/47882924/preventing-double-borders-in-css-grid
-
-
-
-
-
Commits on Nov 8, 2023
-
Tweak styles to resemble previous version
Now borders are more similar to that of previous version, except double borders are avoided if possible.
-
-
Commits on Nov 10, 2023
-
Update packages/nbdime/src/styles/common.css
Co-authored-by: Michał Krassowski <[email protected]>
-
Tweak styles for border some more
Including fixing a broken style that used a private variable.
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.