Remove bower and use npm to install dependencies #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RRosio Thx for this PR. Can you please add a topic to today agenda https://hackmd.io/gl6x_SL0S_aYVn0Y0lSBpQ?both to discuss this. |
…ed with npm, into components folder. this is applying the changes made by @minrk in https://github.com/jupyter/notebook/pull/6213/files to nbclassic
|
Closing this PR to open another based off of current main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: implements the changes from the PR #6213 on jupyter/notebook by @minrk and is based on PR #96 by @echarles
remove bower
address 403 response for favicons