nbclassic to use its own static assets #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarles
commented
May 4, 2022
RRosio
reviewed
May 4, 2022
RRosio
reviewed
May 4, 2022
RRosio
reviewed
May 4, 2022
RRosio
reviewed
May 4, 2022
RRosio
reviewed
May 4, 2022
RRosio
reviewed
May 5, 2022
docs/source/examples/Notebook/JavaScript Notebook Extensions.ipynb
Outdated
Show resolved
Hide resolved
Co-authored-by: Rosio <[email protected]>
Co-authored-by: Rosio <[email protected]>
Co-authored-by: Rosio <[email protected]>
Co-authored-by: Rosio <[email protected]>
Co-authored-by: Rosio <[email protected]>
…pynb Co-authored-by: Rosio <[email protected]>
RRosio
reviewed
May 9, 2022
RRosio
reviewed
May 9, 2022
RRosio
reviewed
May 9, 2022
Co-authored-by: Rosio <[email protected]>
Co-authored-by: Rosio <[email protected]>
Co-authored-by: Rosio <[email protected]>
2 tasks
|
@Zsailer I have removed
This is ready for review/merge. |
|
more screenshots of the extensions working after launching
|
Zsailer
approved these changes
May 11, 2022
|
Looks good to me, thanks @echarles! |
|
Thx @Zsailer I have merged. We will iterate to further fix the CI and make soon a release 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In jupyter/notebook-team-compass#5 (comment) we have defined that
nbclassicshould have its own assets.Further to #93 and #94, this PR ensure after those commands, the UI is shown and operational.
Before merging, a minimal set of UI tests should be operational.