Add async API #506
Add async API #506
Conversation
|
This allows to have asynchronous execution in jupyter/nbclient#10. |
There was a problem hiding this comment.
Thanks for working on such a functional PR. Overall the changes seem like a fairly transparent clone of the synchronous client. I'd like to see this be merged and released as it'd help with a major gap in jupyter's python execution framework. While I don't think I'd block merging this to get things moving forward, we probably need tests for the new async paths to help ensure it doesn't break in the future.
That being said, I started helping with this project after these changes were in master but releases were only happening out of the 5.x branch (for a couple years now). @takluyver @Carreau @rgbkrk @mpacer @kevin-bates I might need buy in from you all on what was the state / intention with master branch and if that code should move to an experimental branch instead of master? The two branches are heavily deviated and I haven't worked through what the actual diff encompasses yet.
|
Thanks for reviewing @MSeal, I made some changes according to your comments. |
|
this looks good to me. |
|
Everyone, I am going to merge this unless someone comments in the next few hours. |
|
@SylvainCorlay OK to merge? |
|
Done! |
|
Did folks come to a resolution on |
|
I created a PR to forward-port |
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: |
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/welcome-new-jupyter-client-nbclient-maintainer-david-brochart/3467/1 |
No description provided.