feat: add client class that uses async/await to integrate with asyncio #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2019
|
@maartenbreddels should we consider that this is superceded by #506? |
|
It seems that @davidbrochart's version's of |
|
No, this was experimentation/proof of concept only, happy to see this superseded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental async jupyter client class, used in voila-dashboards/voila#374 for performance reasons for voila (makes the server much more responsive).
This is basically copy/paste work with some async/await sprinkled on top and used as the proof of concept for voila. Also, I think it's good there is some code out so people can experiment/look/learn.
Feedback is welcome on where this should go, I have no strong opinions on this.
ref: jupyter/nbconvert#1092
related PRs/issues: takluyver/jupyter_kernel_mgmt#23 jupyter/nbconvert#809 #428 #266