Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutputWidget: use public API to get parent header #3199

Merged

Conversation

minrk
Copy link
Contributor

@minrk minrk commented May 8, 2021

getting the parent now has a public API in 6.0 (alpha), so use that when available instead of the private Kernel._parent_header, which is deprecated in favor of the public method now that we have it.

Added in ipython/ipykernel#661

newly public in 6.0, Kernel._parent_header is private and deprecated in 6.0
@SylvainCorlay
Copy link
Member

Thanks. This is a longstanding issue!

@SylvainCorlay SylvainCorlay merged commit 2e040b5 into jupyter-widgets:master May 8, 2021
@jasongrout jasongrout added this to the 8.0 milestone Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants