Add Kernel.get_parent to match set_parent #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of get_parent_header, since it's actually returning the parent *message* not the parent header
|
LGTM. Indeed, symetry is nicer. |
SylvainCorlay
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the now-deprecated
_parent_headerwas actually the parent message, but we don't need to keep having that mismatch in a new public API.instead of
get_parent_header, since it's actually returning the parent message not the parent headerAlternative to #660, which stores and returns just the header instead of the whole request.
We've only ever used the header, so either one ought to work fine
I think I have a slight preference for this one over #660, but I don't think it makes much difference. If we find that we ever need public API access to the content or metadata of the request, only this one will do.
closes #660