Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove value from the Image repr #2111

Merged
merged 4 commits into from
Jul 16, 2018
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions ipywidgets/widgets/widget_image.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
Represents an image in the frontend using a widget.
"""
import mimetypes
import hashlib

from .widget_core import CoreWidget
from .domwidget import DOMWidget
Expand Down Expand Up @@ -128,3 +129,27 @@ def _guess_format(cls, filename):
return mtype[len('image/'):]
except Exception:
return None

def __repr__(self):
# Truncate the value in the repr, since it will
# typically be very, very large.

def hash_string(s):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not define a new function every time we do a repr.

return hashlib.md5(s.encode("utf8")).hexdigest()

class_name = self.__class__.__name__

# Return value first like a ValueWidget
signature = []
sig_value = str(self.value)
if len(str(self.value)) > 100:
sig_value = '<base64, hash={}...>'.format(hash_string(sig_value)[:16])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't know that it is base64, do we? It might be a very long URL.

I like your previous approach of just truncating. Or perhaps we should just enhance the existing repr keys mechanism to let us return a repr form for any key, rather than just whether to include the key or not.

signature.append('%s=%r' % ('value', sig_value))

for key in super(Image, self)._repr_keys():
if key == 'value':
continue
value = str(getattr(self, key))
signature.append('%s=%r' % (key, value))
signature = ', '.join(signature)
return '%s(%s)' % (class_name, signature)