Remove value from the Image repr #2111
Conversation
|
One thing we did e.g. in nbdime and nbval was to say something like |
|
This looks good to me. |
This is based on @vidartf's suggestion, and includes a bit of copy+paste from nbdime
|
I modified this to always present the value (truncated along the lines that @vidartf suggested). A more general solution in |
ipywidgets/widgets/widget_image.py
Outdated
| # Truncate the value in the repr, since it will | ||
| # typically be very, very large. | ||
|
|
||
| def hash_string(s): |
There was a problem hiding this comment.
Let's not define a new function every time we do a repr.
ipywidgets/widgets/widget_image.py
Outdated
| signature = [] | ||
| sig_value = str(self.value) | ||
| if len(str(self.value)) > 100: | ||
| sig_value = '<base64, hash={}...>'.format(hash_string(sig_value)[:16]) |
There was a problem hiding this comment.
We don't know that it is base64, do we? It might be a very long URL.
I like your previous approach of just truncating. Or perhaps we should just enhance the existing repr keys mechanism to let us return a repr form for any key, rather than just whether to include the key or not.
|
This just truncates long |
|
Looks great to me, and works well when I test it too. Thanks! |
lock
bot
added
the
resolved-locked
Right now
Image.__repr__includes the value of the image...which bring my browser to a crashing halt for large images.This is likely not the ideal way to handle this; I'd be happy to change
widget.__repr__to truncate all large values (over maybe 10k characters?) in the repr instead.