Add utility function resolveUrl on manager #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to be able to resolve file URLs relative to the widget's notebook.
|
Thanks @vidartf. This should solve https://github.com/ellisonbg/ipyleaflet/issues/120, which is exactly what you described. |
|
@astrofrog I think you also needed this a while back, and I gave you a dirty hack for it, this looks much cleaner |
|
Thanks! |
|
Should this have been using |
|
Or rather, in addition to. |
|
Mainly to be future proof in case anybody adds another Drive with an overridden getDownloadUrl. |
|
Good question. Can you open another issue so we can discuss, and possibly target to a 7.2.1? |
lock
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to be able to resolve file URLs relative to the widget's notebook.
Example: My widget needs to load an image at the path 'img/earth.jpg'. This is implied to be relative to the path of the current notebook (I cannot see a case where this wouldn't be what the user would expect, but I'm sure someone will come along at some point). In classic notebook, this works out of the box, since the url always incorporates the location of the notebook. For jupyter lab, this is not the case. By adding a utility function on the widget manger, we add a frontend-agnostic way of resolving the URL.