Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we fully resolve lab URLs #2043

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Apr 3, 2018

Fixes resolveUrl on lab manager to give a download URL instead of a server path. The base implementation does not give a server path, so neither should the lab one. This will lead to a disconnect in the widget API name vs that used in jupyterlab, but I think that is acceptable.

@vidartf vidartf added this to the Patch release milestone Apr 3, 2018
@vidartf
Copy link
Member Author

vidartf commented Apr 3, 2018

Xref #1993 .

@vidartf
Copy link
Member Author

vidartf commented Apr 9, 2018

See also jupyterlab/jupyterlab#4265.

@ian-r-rose
Copy link

This looks good to me, though I think that the difference in meaning between JupyterLab and ipywidgets with regard to resolveUrl is unfortunate.

@jasongrout
Copy link
Member

As in you think we should probably have called the widget manager function getDownloadURL, or perhaps something different?

@ian-r-rose
Copy link

Just for consistency, yeah. If memory serves, we used to have a single function to do both, and then we broke it up into two functions in @jupyterlab/services.

@jasongrout
Copy link
Member

Okay. Well, we already released 7.2, so we can deprecate and change it for 8.0 if necessary.

@jasongrout jasongrout merged commit acae915 into jupyter-widgets:master Apr 10, 2018
@vidartf vidartf deleted the fix-lab-resolve branch April 10, 2018 09:28
@jasongrout jasongrout modified the milestones: Patch release, 7.3 Jul 6, 2018
@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:jupyterlab resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants