Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer webbrowser import #1095

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

blink1073
Copy link
Contributor

Fixes #1094

@blink1073 blink1073 added the bug label Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 80.39% // Head: 80.40% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (90d6a40) compared to base (e9735fc).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
+ Coverage   80.39%   80.40%   +0.01%     
==========================================
  Files          68       68              
  Lines        8297     8297              
  Branches     1652     1652              
==========================================
+ Hits         6670     6671       +1     
+ Misses       1198     1197       -1     
  Partials      429      429              
Impacted Files Coverage Δ
jupyter_server/serverapp.py 80.21% <0.00%> (ø)
...ter_server/services/kernels/connection/channels.py 59.91% <0.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blink1073 blink1073 merged commit a50dd7c into jupyter-server:main Nov 25, 2022
@blink1073 blink1073 deleted the make_webrowser_optional branch November 25, 2022 16:25
@blink1073
Copy link
Contributor Author

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter_server that referenced this pull request Nov 25, 2022
blink1073 added a commit that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In OpenWRT python 3.9 version, webbrowser module is not existing
2 participants