Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #1095 on branch 1.x (Defer webbrowser import) #1097

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #1095: Defer webbrowser import

@lumberbot-app lumberbot-app bot added the bug label Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 71.44% // Head: 71.43% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (35c621a) compared to base (66ac73e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1097      +/-   ##
==========================================
- Coverage   71.44%   71.43%   -0.02%     
==========================================
  Files          62       62              
  Lines        7758     7758              
  Branches     1536     1536              
==========================================
- Hits         5543     5542       -1     
- Misses       1825     1826       +1     
  Partials      390      390              
Impacted Files Coverage Δ
jupyter_server/serverapp.py 65.33% <0.00%> (-0.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 enabled auto-merge (squash) November 25, 2022 16:49
@blink1073 blink1073 merged commit 28c9e29 into jupyter-server:1.x Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants