Fix translator usage, remove @jupyterlab/rendermime-interfaces dependency #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-i
force-pushed
the
fix_translate
branch
from
59b4a17
to
5ebf83e
Compare
dlqqq
approved these changes
Feb 13, 2024
andrii-i
added a commit
to andrii-i/jupyter-scheduler
that referenced
this pull request
Feb 13, 2024
andrii-i
added a commit
to andrii-i/jupyter-scheduler
that referenced
this pull request
Feb 13, 2024
andrii-i
added a commit
that referenced
this pull request
Feb 14, 2024
…p non-blocking (#480) (#481) * Make server extension verification call during extension startup non-blocking (#480) * remove async call, make call sync, refactor into a separate function * don't use abbreviations in the verifyServerExtension function or type naming * Update src/index.tsx Co-authored-by: david qiu <[email protected]> * remove unused type * add @jupyterlab/rendermime-interfaces as a dependency * Remove async from activatePlugin function declaration (makes it not async) * set @jupyterlab/rendermime-interfaces version to ^3.8.0 to support all JLab >= 4 --------- Co-authored-by: david qiu <[email protected]> * Fix translator usage, remove @jupyterlab/rendermime-interfaces dependency (#483) * update snapshots * use lowercase "es" is "es2017" as is convention in Project Jupyter * fix 1.x dependencies * fix package manifest to be compatible with JL3 * Make ErrorBoundary return JSX.Element to avoid type conflicts --------- Co-authored-by: david qiu <[email protected]>
andrii-i
added a commit
to andrii-i/jupyter-scheduler
that referenced
this pull request
Feb 15, 2024
…p non-blocking (jupyter-server#480) (jupyter-server#481) * Make server extension verification call during extension startup non-blocking (jupyter-server#480) * remove async call, make call sync, refactor into a separate function * don't use abbreviations in the verifyServerExtension function or type naming * Update src/index.tsx Co-authored-by: david qiu <[email protected]> * remove unused type * add @jupyterlab/rendermime-interfaces as a dependency * Remove async from activatePlugin function declaration (makes it not async) * set @jupyterlab/rendermime-interfaces version to ^3.8.0 to support all JLab >= 4 --------- Co-authored-by: david qiu <[email protected]> * Fix translator usage, remove @jupyterlab/rendermime-interfaces dependency (jupyter-server#483) * update snapshots * use lowercase "es" is "es2017" as is convention in Project Jupyter * fix 1.x dependencies * fix package manifest to be compatible with JL3 * Make ErrorBoundary return JSX.Element to avoid type conflicts --------- Co-authored-by: david qiu <[email protected]>
andrii-i
added a commit
to andrii-i/jupyter-scheduler
that referenced
this pull request
Feb 16, 2024
…p non-blocking (jupyter-server#480) (jupyter-server#481) * Make server extension verification call during extension startup non-blocking (jupyter-server#480) * remove async call, make call sync, refactor into a separate function * don't use abbreviations in the verifyServerExtension function or type naming * Update src/index.tsx Co-authored-by: david qiu <[email protected]> * remove unused type * add @jupyterlab/rendermime-interfaces as a dependency * Remove async from activatePlugin function declaration (makes it not async) * set @jupyterlab/rendermime-interfaces version to ^3.8.0 to support all JLab >= 4 --------- Co-authored-by: david qiu <[email protected]> * Fix translator usage, remove @jupyterlab/rendermime-interfaces dependency (jupyter-server#483) * update snapshots * use lowercase "es" is "es2017" as is convention in Project Jupyter * fix 1.x dependencies * fix package manifest to be compatible with JL3 * Make ErrorBoundary return JSX.Element to avoid type conflicts --------- Co-authored-by: david qiu <[email protected]>
andrii-i
added a commit
that referenced
this pull request
Feb 16, 2024
…tup non-blocking (#480) (#486) * [1.x] Make server extension verification call during extension startup non-blocking (#480) (#481) * Make server extension verification call during extension startup non-blocking (#480) * remove async call, make call sync, refactor into a separate function * don't use abbreviations in the verifyServerExtension function or type naming * Update src/index.tsx Co-authored-by: david qiu <[email protected]> * remove unused type * add @jupyterlab/rendermime-interfaces as a dependency * Remove async from activatePlugin function declaration (makes it not async) * set @jupyterlab/rendermime-interfaces version to ^3.8.0 to support all JLab >= 4 --------- Co-authored-by: david qiu <[email protected]> * Fix translator usage, remove @jupyterlab/rendermime-interfaces dependency (#483) * update snapshots * use lowercase "es" is "es2017" as is convention in Project Jupyter * fix 1.x dependencies * fix package manifest to be compatible with JL3 * Make ErrorBoundary return JSX.Element to avoid type conflicts --------- Co-authored-by: david qiu <[email protected]> * add pytest-cov dependency to pyproject.toml * update pre-commit * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: david qiu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #480 introduced incorrect usage of
translator:IRenderMime.TranslationBundleis passed directly toverifyServerExtensionfunction. Correct pattern is passingITranslatorto any component and then instantiatingIRenderMime.TranslationBundleviatranslator.load('jupyterlab');as it's done everywhere in the codebase, for example here.As a result of this change, translator inside
verifyServerExtensionfunction works correctly and explicit dependency on@jupyterlab/rendermime-interfacesis not needed (this will also simplify PR #481 that backports #480).