Make server extension verification call during extension startup non-blocking #480

andrii-i · 2024-02-09T02:07:57Z

Make server extension verification call in index.ts non-blocking, refactor it into a separate function
Fixes Lab extension makes a blocking call to the server extension on startup #479

To test:

Add a sleep statement like await asyncio.sleep(20) (20 seconds) to JobHandler.get as so:

class JobHandler(ExtensionHandlerMixin, JobHandlersMixin, APIHandler):
    @authenticated
    async def get(self, job_id=None):
        await asyncio.sleep(20)
        ...

Launch the extension with and without this PR, note that with this PR startup is not blocked

src/index.tsx

… naming

src/index.tsx

Co-authored-by: david qiu <[email protected]>

…sync)

…l JLab >= 4

dlqqq

👍

dlqqq · 2024-02-09T21:23:34Z

package.json

@@ -62,6 +62,7 @@
    "@jupyterlab/coreutils": "^6",
    "@jupyterlab/filebrowser": "^4",
    "@jupyterlab/launcher": "^4",
+    "@jupyterlab/rendermime-interfaces": "^3.8.0",


Awesome work diving deep to find the exact minimum version of this package for JL4, after I gave you the wrong version range spec. 😂

When you backport this, you will want to change this to ^3.0.0:

https://github.com/jupyterlab/jupyterlab/blob/v3.0.0/packages/rendermime-interfaces/package.json

I know you already know, but I wanted to save you the time of looking that up ^

Thank you @dlqqq

…blocking (jupyter-server#480) * remove async call, make call sync, refactor into a separate function * don't use abbreviations in the verifyServerExtension function or type naming * Update src/index.tsx Co-authored-by: david qiu <[email protected]> * remove unused type * add @jupyterlab/rendermime-interfaces as a dependency * Remove async from activatePlugin function declaration (makes it not async) * set @jupyterlab/rendermime-interfaces version to ^3.8.0 to support all JLab >= 4 --------- Co-authored-by: david qiu <[email protected]>

…p non-blocking (#480) (#481) * Make server extension verification call during extension startup non-blocking (#480) * remove async call, make call sync, refactor into a separate function * don't use abbreviations in the verifyServerExtension function or type naming * Update src/index.tsx Co-authored-by: david qiu <[email protected]> * remove unused type * add @jupyterlab/rendermime-interfaces as a dependency * Remove async from activatePlugin function declaration (makes it not async) * set @jupyterlab/rendermime-interfaces version to ^3.8.0 to support all JLab >= 4 --------- Co-authored-by: david qiu <[email protected]> * Fix translator usage, remove @jupyterlab/rendermime-interfaces dependency (#483) * update snapshots * use lowercase "es" is "es2017" as is convention in Project Jupyter * fix 1.x dependencies * fix package manifest to be compatible with JL3 * Make ErrorBoundary return JSX.Element to avoid type conflicts --------- Co-authored-by: david qiu <[email protected]>

…p non-blocking (jupyter-server#480) (jupyter-server#481) * Make server extension verification call during extension startup non-blocking (jupyter-server#480) * remove async call, make call sync, refactor into a separate function * don't use abbreviations in the verifyServerExtension function or type naming * Update src/index.tsx Co-authored-by: david qiu <[email protected]> * remove unused type * add @jupyterlab/rendermime-interfaces as a dependency * Remove async from activatePlugin function declaration (makes it not async) * set @jupyterlab/rendermime-interfaces version to ^3.8.0 to support all JLab >= 4 --------- Co-authored-by: david qiu <[email protected]> * Fix translator usage, remove @jupyterlab/rendermime-interfaces dependency (jupyter-server#483) * update snapshots * use lowercase "es" is "es2017" as is convention in Project Jupyter * fix 1.x dependencies * fix package manifest to be compatible with JL3 * Make ErrorBoundary return JSX.Element to avoid type conflicts --------- Co-authored-by: david qiu <[email protected]>

…tup non-blocking (#480) (#486) * [1.x] Make server extension verification call during extension startup non-blocking (#480) (#481) * Make server extension verification call during extension startup non-blocking (#480) * remove async call, make call sync, refactor into a separate function * don't use abbreviations in the verifyServerExtension function or type naming * Update src/index.tsx Co-authored-by: david qiu <[email protected]> * remove unused type * add @jupyterlab/rendermime-interfaces as a dependency * Remove async from activatePlugin function declaration (makes it not async) * set @jupyterlab/rendermime-interfaces version to ^3.8.0 to support all JLab >= 4 --------- Co-authored-by: david qiu <[email protected]> * Fix translator usage, remove @jupyterlab/rendermime-interfaces dependency (#483) * update snapshots * use lowercase "es" is "es2017" as is convention in Project Jupyter * fix 1.x dependencies * fix package manifest to be compatible with JL3 * Make ErrorBoundary return JSX.Element to avoid type conflicts --------- Co-authored-by: david qiu <[email protected]> * add pytest-cov dependency to pyproject.toml * update pre-commit * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: david qiu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

remove async call, make call sync, refactor into a separate function

ef00462

andrii-i added the enhancement New feature or request label Feb 9, 2024

andrii-i changed the title ~~Remove server extension verification async call from index.ts, make it synch~~ Make server extension verification call in index.ts non-blocking Feb 9, 2024

andrii-i marked this pull request as ready for review February 9, 2024 17:42

andrii-i changed the title ~~Make server extension verification call in index.ts non-blocking~~ Make server extension verification call during extension startup non-blocking Feb 9, 2024

JasonWeill reviewed Feb 9, 2024

View reviewed changes

src/index.tsx Outdated Show resolved Hide resolved

src/index.tsx Outdated Show resolved Hide resolved

andrii-i added bug Something isn't working and removed enhancement New feature or request labels Feb 9, 2024

don't use abbreviations in the verifyServerExtension function or type…

da1e844

… naming

andrii-i requested a review from JasonWeill February 9, 2024 18:07

bhadrip reviewed Feb 9, 2024

View reviewed changes

src/index.tsx Show resolved Hide resolved

andrii-i requested a review from bhadrip February 9, 2024 18:22

dlqqq requested changes Feb 9, 2024

View reviewed changes

src/index.tsx Outdated Show resolved Hide resolved

src/index.tsx Show resolved Hide resolved

src/index.tsx Outdated Show resolved Hide resolved

src/index.tsx Show resolved Hide resolved

andrii-i and others added 5 commits February 9, 2024 10:36

Update src/index.tsx

2236acd

Co-authored-by: david qiu <[email protected]>

remove unused type

060bd30

add @jupyterlab/rendermime-interfaces as a dependency

066f506

Remove async from activatePlugin function declaration (makes it not a…

3dbee1e

…sync)

set @jupyterlab/rendermime-interfaces version to ^3.8.0 to support al…

8116a94

…l JLab >= 4

andrii-i requested a review from dlqqq February 9, 2024 20:02

dlqqq approved these changes Feb 9, 2024

View reviewed changes

andrii-i merged commit 060011b into jupyter-server:main Feb 9, 2024
6 checks passed

andrii-i deleted the remove-async branch February 9, 2024 21:32

This was referenced Feb 10, 2024

[1.x] Make server extension verification call during extension startup non-blocking (#480) #481

Merged

Fix translator usage, remove @jupyterlab/rendermime-interfaces dependency #483

Merged

andrii-i mentioned this pull request Feb 16, 2024

[1.1.x] Make server extension verification call during extension startup non-blocking (#480) #486

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make server extension verification call during extension startup non-blocking #480

Make server extension verification call during extension startup non-blocking #480

andrii-i commented Feb 9, 2024 •

edited

Loading

dlqqq left a comment

dlqqq Feb 9, 2024

andrii-i Feb 9, 2024

Make server extension verification call during extension startup non-blocking #480

Make server extension verification call during extension startup non-blocking #480

Conversation

andrii-i commented Feb 9, 2024 • edited Loading

dlqqq left a comment

Choose a reason for hiding this comment

dlqqq Feb 9, 2024

Choose a reason for hiding this comment

andrii-i Feb 9, 2024

Choose a reason for hiding this comment

andrii-i commented Feb 9, 2024 •

edited

Loading