Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds error reporting #277

Merged
merged 5 commits into from
Nov 4, 2022
Merged

Conversation

JasonWeill
Copy link
Collaborator

@JasonWeill JasonWeill commented Nov 4, 2022

Fixes #236. Adds an error handler that intercepts errors and displays a message.

In the example below, the create form has been overridden to throw an exception.

open-create-error

@JasonWeill JasonWeill marked this pull request as draft November 4, 2022 21:19
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Binder 👈 Launch a Binder on branch jweill-aws/jupyter-scheduler/error-handler-hoc

@dlqqq dlqqq added bug Something isn't working enhancement New feature or request labels Nov 4, 2022
src/notebook-jobs-panel.tsx Outdated Show resolved Hide resolved
src/components/error-boundary.tsx Outdated Show resolved Hide resolved
src/components/error-boundary.tsx Show resolved Hide resolved
src/components/error-boundary.tsx Outdated Show resolved Hide resolved
@dlqqq dlqqq marked this pull request as ready for review November 4, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graceful handling for create form errors that cause a blank screen
2 participants