Job definition creation failure due to validation error and show weird error message

[edwardps]

Description

When the job is created using an invalid s3 bucket(e.g. s3 bucket in another different region), the job will be failed due to backend validation. Then the UI show error message like below:

Minified React error #31; visit https://reactjs.org/docs/error-decoder.html?invariant=31&args[]=Error%3A%20S3%20bucket%20-us-west-2%20must%20be%20in%20region%20'us-east-1'%2C%20but%20found%20in%20'us-west-2' for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

Reproduce

Simply use a s3 bucket in different region.

[dlqqq]

Interesting, it looks like we are rendering the error object itself rather than the text? I don't see why this would be the case in #277. I'll investigate this issue further on Monday.

[edwardps]

Thanks David for the investigation.

Can we follow the behavior and show the error message in the job creation page? This enable customer to easily fix the issue without requiring entering configuration from scratch.

[JasonWeill]

I have not been able to reproduce this. I tried to replace createJob with a function that always fails:

  async createJob(
    model: Scheduler.ICreateJob
  ): Promise<Scheduler.ICreateJobResponse> {
    return Promise.reject(
      new ServerConnection.ResponseError(
        new Response(),
        'Rejected because I said so'
      )
    );
  }

When I submit a request, I always get an error message above the form, without hitting the error boundary.

In submitCreateJobRequest, we're already using a try/catch block to catch this error, so it wouldn't hit the error boundary anyway:

jupyter-scheduler/src/mainviews/create-job.tsx

Lines 333 to 345 in 795e702

	api
	.createJob(jobOptions)
	.then(response => {
	// Switch to the list view with "Job List" active
	props.showListView(JobsView.ListJobs);
	})
	.catch((error: Error) => {
	props.handleModelChange({
	...props.model,
	createError: error.message,
	createInProgress: false
	});
	});

[JasonWeill]

I can reproduce this in open source code with a custom handler for job definition creation, but not with one for job creation. A similar try/catch block appears in the submitCreateJobDefinitionRequest function.