-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a JupyterLab extension for the memory usage status bar item #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2020
This was referenced Nov 19, 2020
jtpio
changed the title
Add a JupyterLab extension for nbresuse
Add a JupyterLab extension for the memory usage status bar item
Nov 26, 2020
jtpio
force-pushed
the
labextension
branch
2 times, most recently
from
December 2, 2020 19:56
d4e569e
to
83bc052
Compare
jasongrout
reviewed
Dec 3, 2020
Co-authored-by: RichaGadgil <[email protected]> Co-authored-by: Declan Kelly <[email protected]>
Rebased to include the renaming from |
Closed
I wanted to give this a deeper review, but I have other commitments prior to EOY so for now I can say I tested this locally and it it worked as expected and on an initial pass the code look good. So I'll give this a soft approval |
Thanks @ajbozarth. Just pushed a couple more changes to:
|
2 tasks
This was referenced Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jupyterlab/jupyterlab#9363
In JupyterLab 3.0, users will still get the memory usage status bar item on
pip install nbresuse
.Leveraging the federated (also called "pre-built" / "dynamic") extensions in JupyterLab 3.0: https://jupyterlab.readthedocs.io/en/latest/developer/extension_dev.html#goals-of-the-federated-extension-system
Displays the indicator twice for now, until JupyterLab removes it from the core extensionsEdit: This is not the case anymore when updating to0.4.0
without enabling the/metrics
endpoint.TODO
@jupyter-server/resource-usage
Co-authored-by: name <[email protected]>
entries