Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a JupyterLab extension for the memory usage status bar item #69

Merged
merged 7 commits into from
Dec 11, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 18, 2020

See jupyterlab/jupyterlab#9363

In JupyterLab 3.0, users will still get the memory usage status bar item on pip install nbresuse.

Leveraging the federated (also called "pre-built" / "dynamic") extensions in JupyterLab 3.0: https://jupyterlab.readthedocs.io/en/latest/developer/extension_dev.html#goals-of-the-federated-extension-system

Displays the indicator twice for now, until JupyterLab removes it from the core extensions Edit: This is not the case anymore when updating to 0.4.0 without enabling the /metrics endpoint.

image

TODO

@jtpio jtpio changed the title Add a JupyterLab extension for nbresuse Add a JupyterLab extension for the memory usage status bar item Nov 26, 2020
@jtpio jtpio added this to the 0.5.0 milestone Dec 2, 2020
@jtpio jtpio force-pushed the labextension branch 2 times, most recently from d4e569e to 83bc052 Compare December 2, 2020 19:56
@jtpio jtpio marked this pull request as ready for review December 2, 2020 20:14
@jtpio
Copy link
Member Author

jtpio commented Dec 3, 2020

Rebased to include the renaming from nbresuse to jupyter-resource-usage from #74

@jtpio jtpio mentioned this pull request Dec 9, 2020
@ajbozarth
Copy link

I wanted to give this a deeper review, but I have other commitments prior to EOY so for now I can say I tested this locally and it it worked as expected and on an initial pass the code look good. So I'll give this a soft approval

@jtpio
Copy link
Member Author

jtpio commented Dec 11, 2020

Thanks @ajbozarth.

Just pushed a couple more changes to:

  • Add the Jupyter Server extension config file: jupyter server extension list
  • Move the config to the jupyter-config folder

@jtpio jtpio merged commit eb21378 into jupyter-server:master Dec 11, 2020
@jtpio jtpio deleted the labextension branch December 11, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants