Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to jupyter-resource-usage #73

Closed
8 tasks done
jtpio opened this issue Nov 26, 2020 · 10 comments · Fixed by #74
Closed
8 tasks done

Rename to jupyter-resource-usage #73

jtpio opened this issue Nov 26, 2020 · 10 comments · Fixed by #74
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Nov 26, 2020

Now that the repo has been moved to the jupyter-server organization (jupyter-server/team-compass#3), we should be able to rename the Python package and other instances of nbresuse to jupyter-resource-usage.

And publish a new version on PyPI with the new name.

TODO

@manics
Copy link

manics commented Nov 26, 2020

If you're renaming the package this might be a good opportunity to make any breaking changes? e.g. following up from #68 /metrics could be completely removed instead of just deprecated?

@jtpio
Copy link
Member Author

jtpio commented Nov 26, 2020

Good point.

And include the lab extension for JupyterLab 3: #69

So everything would work with the new endpoint with a single: pip install jupyter-resource-usage.

@jtpio
Copy link
Member Author

jtpio commented Dec 11, 2020

To rename the project on PyPI, we can follow this: https://www.python.org/dev/peps/pep-0423/#how-to-rename-a-project

For conda, we can probably do something similar:

@jtpio jtpio reopened this Dec 11, 2020
@jtpio
Copy link
Member Author

jtpio commented Dec 16, 2020

Also, even though the name of the package changes, we can continue with 0.5.0 for the next version.

Which should make make things less confusing, especially when following the changelog.

@jtpio
Copy link
Member Author

jtpio commented Dec 17, 2020

Since this repo lives in the jupyter-server organization, I just invited the same list of maintainers as for the jupyter-server package: https://pypi.org/project/jupyter-server/ + Yuvi.

Let me know if you would like to be added as a maintainer on PyPI.

@Jeffwan
Copy link

Jeffwan commented Dec 22, 2020

I am new to this area. What does it mean when this repo moved to jupyter-server org? Will this repo ship with jupyter server together?

@jtpio
Copy link
Member Author

jtpio commented Dec 23, 2020

Thanks and welcome @Jeffwan!

The move was done mostly to answer some questions about the maintainability of the project and its future. There are a couple of other projects using it, and some people willing to contribute to it.

There are also some answers in jupyter-server/team-compass#3 and #62.

And the roadmap: #58
With some items talking about having metrics baked in Jupyter Server at some point in the future.

@krassowski
Copy link
Collaborator

It looks like this issue could be closed.

@jtpio
Copy link
Member Author

jtpio commented Dec 17, 2022

yes!

@jtpio jtpio closed this as completed Dec 17, 2022
@jtpio
Copy link
Member Author

jtpio commented Dec 17, 2022

btw @krassowski and / or @echarles (or anyone interested) if you would like to be added as maintainer for the conda package, feel to open a PR on https://github.com/conda-forge/jupyter-resource-usage-feedstock. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants