Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare relase 4.0.0 #912

Merged
merged 10 commits into from
Mar 13, 2023
Merged

Prepare relase 4.0.0 #912

merged 10 commits into from
Mar 13, 2023

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Mar 13, 2023

References

Closes #908, closes #742, workarounds #911.

Code changes

  • Bump version of server extension to 2.0
  • Require Python 3.8
  • Use only Node 16 for development
  • Update tests for JupyterLab 3.6
  • Only support JupyterLab 3.6

User-facing changes

Backwards-incompatible changes

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/maintenance

@krassowski krassowski merged commit 2a87e00 into jupyter-lsp:master Mar 13, 2023
@bollwyvl
Copy link
Collaborator

bollwyvl commented Mar 13, 2023

Only support JupyterLab 3.6

Of note on this: we won't be able to continue "lsp in the browser" work for a while, with a hard dep on lab 3.6, due to the breaking changes from 3.5 (e.g. yjs) (vs jupyterlite/jupyterlite-lsp#1). Probably fine, pretty slammed as it is.

No doubt some time in the 4.x-beta timeline, we'll have something working.

See also:

  • factoring out jupyterlite-pyodide-kernel, making it easier to ship "tricky" packages
    • while getting a JSON/YAML/MD LSP working would still be the first goal,
      • getting something running in-kernel (or at least in-loop) would be pretty great, be it jedi or otherwise
        • for now, just shimming out jedi (and a lot of prompt-toolkit) altogether 😿

@krassowski
Copy link
Member Author

Thanks for the note. It is not a hard dep on 3.6 - just a realistic statement that bugs which are specific to older releases are likely to receive no fixes from us. 3.3+ continuous to work for now, without future guarantees (and is no longer tested on CI).

@krassowski
Copy link
Member Author

But yes install_requires would need to be circumvented to install it on <3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next release anytime soon? 4.0 release plan
2 participants