Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaTeX chktex failing on CI on Windows (again) #894

Closed
krassowski opened this issue Jan 2, 2023 · 6 comments
Closed

LaTeX chktex failing on CI on Windows (again) #894

krassowski opened this issue Jan 2, 2023 · 6 comments
Labels
lang:tex texlab, LaTex, chktex, etc. os:windows

Comments

@krassowski
Copy link
Member

First seen on #892 and then independently on #893. #891 was still ok.

@krassowski
Copy link
Member Author

krassowski commented Jan 2, 2023

This appears to be due to texlab 5.0 release: https://github.com/latex-lsp/texlab/releases/tag/v5.0.0. It was working fine with 4.3.2 and this is the only change in the installed conda packages:

< texlab                    4.3.2                h8b8d39b_0    conda-forge
---
> texlab                    5.0.0                h8b8d39b_0    conda-forge

In both cases this is with:

chktex                    1.7.8                hcd874cb_0    conda-forge

texlab 5.0.0 works fine on Ubuntu (hd9586b0_0) with chktex 1.7.8 (hcd874cb_0) and Mac (h08cba0f_0) also with chktex 1.7.8 (h9e318b2_0).

There does not seem to be anything obviously related in the changelog, nor any recent issues specific to Windows. The changeset is rather large so hard to narrow it down by just looking (over 300 files).

@krassowski
Copy link
Member Author

Nothing suspicious in conda-forge/texlab-feedstock#20 either.

@bollwyvl
Copy link
Collaborator

bollwyvl commented Jan 2, 2023

Yeah, sorry: maybe there's a way we can improve the conda-forge feedstock to test this earlier... I don't have a ready-to-hand headless LSP testing tool, a la jupyter-kernel-test...

@krassowski
Copy link
Member Author

Just for reference this was the previous instance: #815.

@krassowski
Copy link
Member Author

Closing as it is now passing as seen in #912 with version:

texlab                    5.4.0                h8b8d39b_0    conda-forge

@krassowski
Copy link
Member Author

LaTeX :: diagnostics only appear if configured                        | FAIL |

Is now failing on all OSes:

texlab                    5.4.2                hd9586b0_0    conda-forge

It looks that the expectations need to be updated as it is now Command terminated with space. instead of Command terminated with space. (chktex):

image

While release notes do not mention this, the git history shows that diagnostics were refactored between 5.4.0 and 5.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:tex texlab, LaTex, chktex, etc. os:windows
Projects
None yet
Development

No branches or pull requests

2 participants