Implement eliding for paths/files #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
caught on CI. It was only a problem for 3.7 because newer versions of IPython include type information for all suggestions.
|
Windows failures are unrelated (#894). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Elide long path completions, fixes #787 and fixes jupyterlab/jupyterlab#12830
Code changes
The content of the first highlighted (
<mark>ed) part is elided for pathsdirection: rtlis used to reverse side of eliding.or/)<bdo>tag wrapper is used for<mark>contents; the alternative, CSSunicode-bidiwould also require an HTML wrapper, hence BDO tag is a simpler choice.display:flex/flex-shrink: 1is used to stretch the mark to as much as possibleI also explored a possibility of eliding of the middle part of the path based on separator, but there does not appear to be a good solution (which would have good performance with large number of matches).
User-facing changes
Long paths are elided. User can hover over the elided part to see title with full contents.
Backwards-incompatible changes
None
Chores