-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce number of top-level files #180
Conversation
To really go after it, we need all the meta junk from python:
|
Another thought: if the DX is indeed getting onerous, we can fix it Once And For All and introduce a top-level automation tool, and indeed, that might even be worthwhile, especially as we increase the number of built artifacts (#177, #163). If we want to go that way, this PR is a fine place to do it: i find it onerous to incrementally change automation if we can get consensus vision of where we want to go.
Positing Anyhow, food for thought... |
Well, I guess I'll take it passing the first time. No doubt i missed some stuff in the markdown links, but that will be tested aggressively on #177, so less inclined to worry about it at this point... |
@@ -211,7 +211,7 @@ class LSPPopup extends VDomRenderer<LSPStatus.Model> { | |||
Documentation:{' '} | |||
<a | |||
href={ | |||
'https://github.com/krassowski/jupyterlab-lsp/blob/master/LANGUAGESERVERS.md' | |||
'https://github.com/krassowski/jupyterlab-lsp/blob/master/docs/LANGUAGESERVERS.md' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One lazy option would be to point to a version-specific commit and have a link to master in the document itself (something like "there might be an updated version of this document >click here<".)
References
Code changes
Moves a lot of things around. There is a hard reference to
LANGSERVERS.md
in the source: we should probably just inline that or something... or point toreadthedocs
when we do that.User-facing changes
The repo is a tad cleaner on first blush:
Backwards-incompatible changes
shouldn't create any issues on PRs...
Chores