Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start sphinx docs #177

Merged
merged 19 commits into from
Feb 9, 2020
Merged

Start sphinx docs #177

merged 19 commits into from
Feb 9, 2020

Conversation

bollwyvl
Copy link
Collaborator

@bollwyvl bollwyvl commented Jan 24, 2020

References

Code changes

Goals for this PR:

  • collect envs/reqs into a folder
    • Adds new (nb)sphinx env/requirements
  • Adds doc script
  • Handle some initial documentation tasks
  • icon
  • review some best practices
  • Add docs to automation
    • integrity
    • linting
    • CI
  • integrate existing content:
    • ROADMAP
    • README
    • CONTRIBUTNG
    • LANGUAGESERVERS
    • EXTENDING

(Maybe) non-goals for this PR:

  • add readthedocs
  • add screenshots/gifs from acceptance tests

User-facing changes

None, yet

Backwards-incompatible changes

None, yet

Chores

  • linted
  • tested
  • documented
  • changelog entry

@bollwyvl
Copy link
Collaborator Author

Working on the docs locally with autoreload:
Screenshot from 2020-01-24 09-44-23

requirements-docs.txt Outdated Show resolved Hide resolved
This was referenced Jan 25, 2020
@bollwyvl bollwyvl changed the title [wip] Start sphinx docs Start sphinx docs Feb 9, 2020
@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Feb 9, 2020

This is mostly wired up now, and at least generates the docs on azure. I've also updated the architecture pieces a fair amount (i.e. documented #165 here, rather than on that branch), and spent a little more time on the install piece. There are a number of outstanding issues, of course, but it might make sense to merge and move forward more incrementally: it's not ready to start publishing on readthedocs, and indeed, we may not want to do so, if we want to use screenshots from the acceptance tests in the docs.

Some future, non-content thoughts:

@bollwyvl bollwyvl requested a review from krassowski February 9, 2020 01:11
@bollwyvl bollwyvl added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Feb 9, 2020
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental progress is the best kind of progress!


Language Server Specs can be [configured](./LANGUAGESERVERS.ms) by Jupyter users,
Language Server Specs can be [configured](./LANGUAGESERVERS.md) by Jupyter users,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@krassowski
Copy link
Member

Waiting for the CI to pass before I merge.

@krassowski krassowski merged commit f75be86 into jupyter-lsp:master Feb 9, 2020
@krassowski
Copy link
Member

The tests like to fail on master...

bollwyvl added a commit to bollwyvl/jupyterlab-lsp that referenced this pull request Feb 11, 2020
@bollwyvl bollwyvl mentioned this pull request Feb 11, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants