Add commands to palette, add diagnostics panel tests #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
changed the title
krassowski
added a commit
to yunair/jupyterlab-lsp
that referenced
this pull request
Jan 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands are now also accessible from the command palette, while diagnostics panel is tested during diagnostics tests.
References
A prerequisite for a test and fix for #141.
Code changes
ContextMenuCommandManagerbecameContextCommandManagerand takes care of attachment, visibility and execution of commands invoked from both the context menu and commands palette.User-facing changes
One can discover options of the extension via the command palette.
Backwards-incompatible changes
ContextCommandManagerand its constructor.Chores