Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics are not cleared upon file rename #141

Closed
krassowski opened this issue Jan 7, 2020 · 0 comments · Fixed by #145
Closed

Diagnostics are not cleared upon file rename #141

krassowski opened this issue Jan 7, 2020 · 0 comments · Fixed by #145
Labels
bug Something isn't working

Comments

@krassowski
Copy link
Member

Description

This can be seen clearly in DiagnosticsPanel of a notebook after rename. Needs a browser test.

Reproduce

  1. Open notebook and the DiagnosticsPanel
  2. Rename notebook
  3. See the diagnostics displayed twice, once for old filename and once for the new filename

Context

  • JupyterLab version: 1.2.4
  • @krassowski/jupyterlab-lsp version: 0.7.0-beta.1
@krassowski krassowski added the bug Something isn't working label Jan 7, 2020
@krassowski krassowski mentioned this issue Jan 7, 2020
Merged
4 tasks
krassowski added a commit that referenced this issue Jan 8, 2020
@krassowski
Clean diagnostics upon rename (fixes #141),
28c60c5 
add dedicated tests for interface (including for diagnostics panel)
@krassowski krassowski mentioned this issue Jan 8, 2020
Merged
4 tasks
@bollwyvl bollwyvl mentioned this issue Feb 2, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean diagnostics upon rename, more panel tests jupyter-lsp/jupyterlab-lsp
1 participant
@krassowski