Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues found by PVS-Studio static analyzer #5 #25

Merged
merged 25 commits into from
Oct 26, 2023
Merged

Fix issues found by PVS-Studio static analyzer #5 #25

merged 25 commits into from
Oct 26, 2023

Commits on Oct 25, 2023

  1. mpeg: Correctly detect DVB metadata

    @dimhotepus
    dimhotepus committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0b94a3a View commit details
    Browse the repository at this point in the history

  2. mpeg: byte always <= byte.MaxValue

    @dimhotepus
    dimhotepus committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    f218d28 View commit details
    Browse the repository at this point in the history

  3. rtp: Ensure correct evaluation order

    @dimhotepus
    dimhotepus committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    cb8af55 View commit details
    Browse the repository at this point in the history

  4. rtspserver: Name maintenance thread to simplify debugging

    @dimhotepus
    dimhotepus committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    d140768 View commit details
    Browse the repository at this point in the history

  5. rtp: Use pattern matching to speedup events handling

    @dimhotepus
    dimhotepus committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    f371f60 View commit details
    Browse the repository at this point in the history

  6. rtp: Use ValueTuple with named members for events queue

    @dimhotepus
    dimhotepus committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    a4c88d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. sln: Drop unreferenced stuff

    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    5b57d14 View commit details
    Browse the repository at this point in the history

  2. sln: Drop Program.cs from dll assemblies 

    DLLs are not executables, no need for Program.cs
    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    a0346a8 View commit details
    Browse the repository at this point in the history

  3. sln: HandleProcessCorruptedStateExceptions is not supported in .net core 

    'HandleProcessCorruptedStateExceptionsAttribute' is obsolete: 'Recovery from corrupted process state exceptions is not supported; HandleProcessCorruptedStateExceptionsAttribute is ignored.' (https://aka.ms/dotnet-warnings/SYSLIB0032)
    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    ab6c5eb View commit details
    Browse the repository at this point in the history

  4. sln: No sense in ReferenceEquals for structs, as they are boxed and n… 

    …ever null
    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    ca83864 View commit details
    Browse the repository at this point in the history

  5. sln: Do not miss original stack trace for exceptions

    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    79643f9 View commit details
    Browse the repository at this point in the history

  6. common: IPAddress.Address is safe to use in IPv4 context

    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    7e408c0 View commit details
    Browse the repository at this point in the history

  7. containers: Drop obsolete MediaFileStream ctors

    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    7a69cb0 View commit details
    Browse the repository at this point in the history

  8. rtsp: Drop unused variables

    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    91801ca View commit details
    Browse the repository at this point in the history

  9. rtsp: Drop Socket.UseOnlyOverlappedIO as it do nothing is .net core 

    [Obsolete("UseOnlyOverlappedIO has been deprecated and is not supported.")]
[EditorBrowsable(EditorBrowsableState.Never)]
public bool UseOnlyOverlappedIO
{
    get { return false; }
    set { }
}
    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    46c4d77 View commit details
    Browse the repository at this point in the history

  10. sdp: When TimeDescription defines Equals, it should also define GetHa… 

    …shCode
    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d2ef6a9 View commit details
    Browse the repository at this point in the history

  11. concepts: Type parameter 'T' has the same name as the type parameter … 

    …from outer type Unsafe.UnsafeList<T>
    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    7f62e57 View commit details
    Browse the repository at this point in the history

  12. sln: Structs can't be null

    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    af7f2e5 View commit details
    Browse the repository at this point in the history

  13. sln: Remove unneded type parameter from TaggedException<T>.DefaultExc… 

    …eptionTypeMessage()
    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    53e55a1 View commit details
    Browse the repository at this point in the history

  14. common: Drop obsolete in .net core stuff

    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    dc5df94 View commit details
    Browse the repository at this point in the history

  15. rtspserver: Include maintenance thread id into its name

    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    61fca13 View commit details
    Browse the repository at this point in the history

  16. rtp: Use better name for RtpFrame var

    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9a95e68 View commit details
    Browse the repository at this point in the history

  17. rtspserver: Comment instead of removing line

    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    3510976 View commit details
    Browse the repository at this point in the history

  18. rtspserver: Use server thread name for maintenance thread

    @dimhotepus
    dimhotepus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    8fb9f97 View commit details
    Browse the repository at this point in the history

  19. sdp: Simplify TimeDescriptoin.GetHashCode() implementation

    @dimhotepus
    dimhotepus committed Oct 26, 2023
    2 Configuration menu
    Copy the full SHA
    799e83f View commit details
    Browse the repository at this point in the history