Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues found by PVS-Studio static analyzer #5 #25

Merged
merged 25 commits into from
Oct 26, 2023

Conversation

dimhotepus
Copy link
Contributor

Copy link
Owner

@juliusfriedman juliusfriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things to change and this will be ready for merge.

Rtp/RtpClient.cs Outdated Show resolved Hide resolved
'HandleProcessCorruptedStateExceptionsAttribute' is obsolete: 'Recovery from corrupted process state exceptions is not supported; HandleProcessCorruptedStateExceptionsAttribute is ignored.' (https://aka.ms/dotnet-warnings/SYSLIB0032)
[Obsolete("UseOnlyOverlappedIO has been deprecated and is not supported.")]
[EditorBrowsable(EditorBrowsableState.Never)]
public bool UseOnlyOverlappedIO
{
    get { return false; }
    set { }
}
Copy link
Owner

@juliusfriedman juliusfriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution's!

I look forward to working with you on this project!

@juliusfriedman juliusfriedman merged commit 9d48e34 into juliusfriedman:master Oct 26, 2023
3 checks passed
@dimhotepus dimhotepus deleted the pvs-studio-fixes-5 branch October 26, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants