Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto-changelog #883

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Update auto-changelog #883

merged 2 commits into from
Jun 28, 2018

Conversation

cookpete
Copy link
Contributor

Checklist

  • Have you linked to relevant open issues?: No (there is no relevant issue)
  • I agree for this to be covered by the Velocity license?: Yes

Please describe this Pull Request in as much detail as possible:

The format of the current changelog is a bit off as it includes multiple lines of the commit message, resulting in lines where the fixes are repeated:

The problem is that auto-changelog uses git log behind the scenes, which assumes that the commit subject and body are separated by two newlines. It appears that the commits in this repo only have a single newline after the first line of the commit message.

I've added a fix to auto-changelog that should sort this issue. I've also committed the fixed changelog as part of this PR, even though it will be fixed from now on every time you npm version.

People who contributed to this change:

@Rycochet
Copy link
Collaborator

I hadn't even noticed that was the issue - there's been a lot of commits with bad messages over the years here!

@Rycochet Rycochet merged commit cc2bbb2 into julianshapiro:master Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE compatibility broken. Promise is undefined. [v2.0.3]
2 participants