Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE compatibility broken. Promise is undefined. [v2.0.3] #875

Closed
nreynis opened this issue May 28, 2018 · 1 comment · Fixed by #883
Closed

IE compatibility broken. Promise is undefined. [v2.0.3] #875

nreynis opened this issue May 28, 2018 · 1 comment · Fixed by #883
Labels
3 - Needed

Comments

@nreynis
Copy link

nreynis commented May 28, 2018

Your system information

  • VelocityJS version: 2.0.3
  • Browser: IE (not edge) all versions
  • Operating System: Windows 10

Using velocity throws a Reference Error Promise is undefined.
Supporting IE probably requires a polyfill.

JSFiddle example showing issue in action (code):

https://codepen.io/anon/pen/jKNaqg
@nreynis nreynis changed the title IE compatibility broken. Promise is undefined. IE compatibility broken. Promise is undefined. [v2.0.3] May 28, 2018
@Rycochet
Copy link
Collaborator

IE does require a polyfill for Promise, but it should work without an error (just result in not having any promises).

@cookpete cookpete mentioned this issue Jun 28, 2018
Merged
Rycochet added a commit that referenced this issue Aug 3, 2020
@Rycochet
Grab Promise in a try/catch Fixes #875
5fd16ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 - Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update auto-changelog cookpete/velocity
2 participants
@Rycochet @nreynis