Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent console.log error in IE9 or less #756

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Prevent console.log error in IE9 or less #756

merged 1 commit into from
Mar 17, 2017

Conversation

paulfalgout
Copy link
Contributor

console.log doesn't always exist, so this throws an error

@paulfalgout
Prevent console.log error in IE9 or less
afc7234 
console.log doesn't always exist, so this throws an error
@Rycochet
Copy link
Collaborator

While this is a good change to add for backwards compatibility, until #746 and #747 are confirmed as fixed it's probably better to leave it in place (though i really hope to get some time for this tomorrow).

@paulfalgout
Copy link
Contributor Author

paulfalgout commented Feb 24, 2017 •
edited
Loading

FWIW the animation throwing this console.log / error in IE9 works without issue. nope not entirely

@Rycochet Rycochet self-assigned this Feb 24, 2017
@Rycochet Rycochet merged commit efd18aa into julianshapiro:master Mar 17, 2017
@paulfalgout paulfalgout deleted the patch-1 branch March 17, 2017 09:26
Rycochet pushed a commit that referenced this pull request Aug 3, 2020
@paulfalgout @Rycochet
Prevent console.log error in IE9 or less (#756)
392533b 
console.log doesn't always exist, so this throws an error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Rycochet Rycochet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulfalgout @Rycochet