Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to 1.4.2 has stopped animation working in IE9 #746

Closed
garethadavies opened this issue Feb 6, 2017 · 1 comment
Closed

Upgrade to 1.4.2 has stopped animation working in IE9 #746

garethadavies opened this issue Feb 6, 2017 · 1 comment
Assignees
@Rycochet
Labels
Bug IMPORTANT

Comments

@garethadavies
Copy link

Hi,

I have recently upgraded from version 1.3.1 to 1.4.2 (alongside velocity-react v1.2.1) and have noticed that all my animations have stopped working in IE9 (see error in console below)

screen shot 2017-02-06 at 14 32 42

Has IE9 support been dropped?

I have tracked down the point IE9 stopped working to this commit: 04e6c35?diff=split

I can revert back to 1.3.1 but it'd be great to be able to use the latest code.

Thanks
@Rycochet
Copy link
Collaborator

Rycochet commented Feb 7, 2017

I'm really busy in general right now, but will try to look into this asap.

Please be aware that using any form of Browser / Document Mode is wrong and broken - you need to actually run in IE9 to test things (via BrowserStack, or a virtual machine etc) - I've been hit by things working in newer IE when telling it to behave like an older one, but breaking on the real browser (and vica-versa).

This was referenced Feb 21, 2017
Closed
Merged
@Rycochet Rycochet self-assigned this Feb 24, 2017
paulfalgout added a commit to paulfalgout/velocity that referenced this issue Feb 24, 2017
@paulfalgout
IE9 sometimes checks again window which can have length 0
e130502 
Fixes julianshapiro#746 and maybe julianshapiro#747 (didn't test IE8)
@paulfalgout paulfalgout mentioned this issue Feb 24, 2017
Merged
Rycochet pushed a commit that referenced this issue Mar 17, 2017
@paulfalgout @Rycochet
IE9 sometimes checks again window which can have length 0 (#757)
beb71a1 
Fixes #746 and maybe #747 (didn't test IE8)
Rycochet pushed a commit that referenced this issue Aug 3, 2020
@paulfalgout @Rycochet
IE9 sometimes checks again window which can have length 0 (#757)
a948817 
Fixes #746 and maybe #747 (didn't test IE8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rycochet Rycochet

Labels
Bug IMPORTANT
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rycochet @garethadavies