-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: Store Velocity version #95
Comments
Thanks, Allan! The problem with assigning a SEM string value is forcing the third-party plugin to parse it so that it can be numerically compared against a base required version. Although I guess that's pretty simple to do: Just strip out the periods and compare integer values. I also wonder what the common use cases for this are? After all, for simple reference purposes, the version number is always included in the comment banner. |
It's a good idea to offer this kind of information!
|
Thanks, Allan :) Would love it if anyone else could chime in with specific instances where this was useful to them in the past. I ask because I'll have to manually update this number on every push, and I'd like to avoid unnecessary manual overhead. Already have to do it for my package.json, component.json, and bower.json :-p |
I understand your concern. Please see: https://github.com/allanesquina/version I can do if you want! |
Awesome! Will take a look at this tomorrow morning. |
Ok man! |
So if you have |
Totally right. Thanks, Tom.
This is awesome. This is exactly what I was waiting for. Given the small likelihood of its use in front-end dev (Velocity of course has no use on the backend), I'm going to close this issue and avoid storing the version as a variable for now. I just don't see the use. I'm open to revisiting this in the future if important use cases come up. If someone wants to enlighten me, please do so. Thanks again for all your contributions, Allan. I hope I have not discouraged you from continuing to participate. I'd love to see more issues raised from you. And thanks to you, @tomByrer, for helping us reach a conclusion on this. |
That's cool, I did not know node-semver. It is a good solution. It's always good to learn more, thanks @tomByrer. |
If you do use semver, use the convention: http://semver.org/ |
Welcome Allan.
Yes, or even if the versioning looks like SemVer, use the official SemVer. |
This is now integrated. |
Cool, I'll update the Library-Detector-for-Chrome to get the library version. |
What do you think about put a version on a property?
Ex: jQuery.fn.jquery // "1.7.1"
The text was updated successfully, but these errors were encountered: