Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Pack: Height animation with dynamic child elements #110

Closed
marcselman opened this issue Jun 13, 2014 · 7 comments
Closed

UI Pack: Height animation with dynamic child elements #110

marcselman opened this issue Jun 13, 2014 · 7 comments

Comments

@marcselman
Copy link

Hi,

I've made a small demo to illustrate what I would like to achieve:
http://www.marcselman.com/velocity/smooth-space.html
Check the 'In' transitions with a stagger of 300.

As you can see the container has an height of 'auto' and the required space for the elements is claimed in a smooth animation.

It's a simple dirty hack in http://www.marcselman.com/velocity/jquery.velocity.js around lines 1390 to 1425.

Would it be possible to add a option to Velocity (animateParentHeight or something) which resizes the parent when animating elements in or out of view?
I think it could be a unique and liked feature.

I don't really see any way I could do this without changing the source code.

@julianshapiro julianshapiro changed the title Smooth space for containers with auto height Feature: Height animation with dynamic child elements Jun 13, 2014
@julianshapiro julianshapiro changed the title Feature: Height animation with dynamic child elements Enhancements: Height animation with dynamic child elements Jun 13, 2014
@julianshapiro julianshapiro changed the title Enhancements: Height animation with dynamic child elements Enhancement: Height animation with dynamic child elements Jun 13, 2014
@julianshapiro julianshapiro changed the title Enhancement: Height animation with dynamic child elements Height animation with dynamic child elements Jun 26, 2014
@julianshapiro julianshapiro changed the title Height animation with dynamic child elements UI Pack: Height animation with dynamic child elements Jul 1, 2014
@julianshapiro
Copy link
Owner

I think I'm going to code this directly into the UI pack. Stay tuned.

@marcselman
Copy link
Author

Awesome, thanks! I will then write a Knockout JS custom binding for Velocity UI.

@tsriram
Copy link

tsriram commented Jul 3, 2014

Cool! Will wait

-Sri

On Thu, Jul 3, 2014 at 8:36 PM, Julian Shapiro [email protected]
wrote:

Not yet. It's next up.

Sent from my iPhone

On Jul 3, 2014, at 7:42 AM, Sriram [email protected] wrote:

Wonder if this is coded already!? Not able to see the desired results
with the latest UI Pack.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#110 (comment)
.

@julianshapiro
Copy link
Owner

Lol. I just coded this feature into my local copy of the UI pack. It's cool as shit.

Problem is, it's fundamentally not very performant. Triggers a ton of unavoidable layout thrashing. Wouldn't have much of a visible impact in most/low-stress situations, but still against my wishes.

Will chew on this.

@tsriram
Copy link

tsriram commented Jul 4, 2014

👍 can't wait to see it in action!

@julianshapiro
Copy link
Owner

OK. So this is finally integrated. But I haven't documented it yet. I'm going to create a new thread tonight or tomorrow morning in which I'll explain how to use it plus ask you guys for feedback. Stay tuned.

In the meantime, update Velocity and the UI pack.

@julianshapiro
Copy link
Owner

Damn. There's a bug. Will fix and follow up tomorrow.

Rycochet pushed a commit that referenced this issue Aug 3, 2020
Closes #153. Closes #110. Closes #143. Closes #95. Closes #156.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants