Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NS_ERROR_FAILURE: animating svg mask #352

Closed
andrespi opened this issue Nov 12, 2014 · 6 comments
Closed

NS_ERROR_FAILURE: animating svg mask #352

andrespi opened this issue Nov 12, 2014 · 6 comments

Comments

@andrespi
Copy link

i'm trying to animate the width property of a mask rect in svg , and i get this error: " NS_ERROR_FAILURE:
propertyValue = element.getBBox()[property];"
@ydaniv
Copy link
Contributor

ydaniv commented Nov 13, 2014

Which browsers?
Could it be that that SVG element is not attached to the DOM or not rendered yet when you call it?
See this bug in FireFox.

@andrespi
Copy link
Author

Yes i've seen it, i fixed it with some extra code. velocity can't get the with so i did a " from to " animation, so velocity don't have to guess the starting width.
JS fiddle ASAP

@andrespi
Copy link
Author

here is the fiddle
http://jsfiddle.net/nenezito/wvn8tcxs/6/

@ydaniv
Copy link
Contributor

ydaniv commented Nov 19, 2014

So where is the error?

@andrespi
Copy link
Author

No error in the fiddle, i put "width: [200, 300]" in the smallerMask function instead of "width:200" and it fixed the "element.getBBox()" bug in firefox for me

@julianshapiro
Copy link
Owner

Silly FF'ers won't fix the bug, so I've just thrown a try/catch around it. This will be implemented in the upcoming release (this weekend). Thanks a bunch @andrespi and @ydaniv!

Rycochet pushed a commit that referenced this issue Aug 3, 2020
@julianshapiro @Rycochet
1.2.0
242770c 
Closes #293. You can now pass a `tween` property for creating arbitrary
tween callbacks via the `progress` function. Refer to
VelocityJS.org/#progress for more information.

Created e/p/o shorthands for elements/properties/options syntactic
sugar arguments syntax. Refer to VelocityJS.org/#arguments to learn
more.

Closes #368. The stop command now has increased targeting for `queue:
false` animations, and is more robust. Refer to VelocityJS.org/#stop
for more.

Closes #396. Easing functions are now passed `opts` and `tweenDelta` so
that custom easing functions can have greater access to animation
parameters. Refer to VelocityJS.org/#easing for more.

Closes #343. Differently-colored border colors don’t throw off
`border-color` animation anymore.

Closes #321. Implements “finish” feature for prematurely stopping
current animations, but having them reach their end values and trigger
their corresponding callbacks. Refer to VelocityJS.org/#finish for more.

Closes #352. Prevents Firefox from throwing an error when animating an
SVG element that isn’t being visually rendered.

Closes #317. Array compacting now happens within ticks to ensure loops
don’t cause arrays to bloat. Thanks so much, @marvelousNinja!

Closes #324. HTML tables and tbody’s now have their proper display
values set by Velocity. Thanks so much to @dtreiter and @okrad!

Closes #371. Looping `backgroundPositionX/Y` to 100% causes a proper
incrementing loop instead of alternation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ydaniv @julianshapiro @andrespi