Set the non-"none" display value for tables in certain redirects, like fadeIn/Out #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects, such as fadeIn/Out. Previously a table would be assigned 'display:block' in getDisplayType(). Now defaults to 'table'.
|
Oops. Thanks for this. I'll have this fixed in the next release :) |
|
I have a similar issue with tbody tags... I think the default display in this case should be "table-row-group". Could you fix this too? Thanks for the great work! |
|
Oops! Fixed. Expect it in the next release. Thanks :) |
|
Because I am a moron and I was juggling a lot of pr's/requests, your changes got implemented but went unaccredited. I am super sorry about this. This will be making it into tomorrow's release, however, and I'll be giving you a mention in the comments. |
julianshapiro
added a commit
that referenced
this pull request
Jan 5, 2015
Closes #293. You can now pass a `tween` property for creating arbitrary tween callbacks via the `progress` function. Refer to VelocityJS.org/#progress for more information. Created e/p/o shorthands for elements/properties/options syntactic sugar arguments syntax. Refer to VelocityJS.org/#arguments to learn more. Closes #368. The stop command now has increased targeting for `queue: false` animations, and is more robust. Refer to VelocityJS.org/#stop for more. Closes #396. Easing functions are now passed `opts` and `tweenDelta` so that custom easing functions can have greater access to animation parameters. Refer to VelocityJS.org/#easing for more. Closes #343. Differently-colored border colors don’t throw off `border-color` animation anymore. Closes #321. Implements “finish” feature for prematurely stopping current animations, but having them reach their end values and trigger their corresponding callbacks. Refer to VelocityJS.org/#finish for more. Closes #352. Prevents Firefox from throwing an error when animating an SVG element that isn’t being visually rendered. Closes #317. Array compacting now happens within ticks to ensure loops don’t cause arrays to bloat. Thanks so much, @marvelousNinja! Closes #324. HTML tables and tbody’s now have their proper display values set by Velocity. Thanks so much to @dtreiter and @okrad! Closes #371. Looping `backgroundPositionX/Y` to 100% causes a proper incrementing loop instead of alternation.
Rycochet
pushed a commit
that referenced
this pull request
Aug 3, 2020
Closes #293. You can now pass a `tween` property for creating arbitrary tween callbacks via the `progress` function. Refer to VelocityJS.org/#progress for more information. Created e/p/o shorthands for elements/properties/options syntactic sugar arguments syntax. Refer to VelocityJS.org/#arguments to learn more. Closes #368. The stop command now has increased targeting for `queue: false` animations, and is more robust. Refer to VelocityJS.org/#stop for more. Closes #396. Easing functions are now passed `opts` and `tweenDelta` so that custom easing functions can have greater access to animation parameters. Refer to VelocityJS.org/#easing for more. Closes #343. Differently-colored border colors don’t throw off `border-color` animation anymore. Closes #321. Implements “finish” feature for prematurely stopping current animations, but having them reach their end values and trigger their corresponding callbacks. Refer to VelocityJS.org/#finish for more. Closes #352. Prevents Firefox from throwing an error when animating an SVG element that isn’t being visually rendered. Closes #317. Array compacting now happens within ticks to ensure loops don’t cause arrays to bloat. Thanks so much, @marvelousNinja! Closes #324. HTML tables and tbody’s now have their proper display values set by Velocity. Thanks so much to @dtreiter and @okrad! Closes #371. Looping `backgroundPositionX/Y` to 100% causes a proper incrementing loop instead of alternation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like getDisplayType() was defaulting HTML tables to be assigned "display:block;" after a fadeIn. I found that we were getting some weird display issues because of this. I think it makes sense to default to "display:table;" instead.
Is there any reason not to?